Make MatchableResources configurable through flyte-cli #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katrogan
requested review from
kumare3,
matthewphsmith and
wild-endeavor
as code owners
katrogan
requested review from
anandswaminathan
and removed request for
matthewphsmith and
kumare3
|
I still don't like the name MatchableResource |
Codecov Report
@@ Coverage Diff @@
## master #118 +/- ##
==========================================
- Coverage 81.60% 81.52% -0.08%
==========================================
Files 211 213 +2
Lines 13745 13878 +133
Branches 1133 1140 +7
==========================================
+ Hits 11216 11314 +98
- Misses 2262 2295 +33
- Partials 267 269 +2
Continue to review full report at Codecov.
|
kumare3
reviewed
Jun 1, 2020
flytekit/clis/flyte_cli/main.py
Outdated
|
|
||
| Use a -- to separate arguments to this cli, and attributes used for cluster resource configuration. | ||
| e.g. | ||
| $ flyte-cli -h localhost:30081 -p flyteexamples -d development update-cluster-resource-attributes -- critical \ |
There was a problem hiding this comment.
It seems this would be better with like a YAML?
There was a problem hiding this comment.
There was a problem hiding this comment.
updated to use multi value options, thanks for the suggestions!
|
friendly ping |
flytekit/clis/flyte_cli/main.py
Outdated
|
|
||
| Use a -- to separate arguments to this cli, and attributes used for cluster resource configuration. | ||
| e.g. | ||
| $ flyte-cli -h localhost:30081 -p flyteexamples -d development update-cluster-resource-attributes \ |
There was a problem hiding this comment.
yep thanks for catching
|
+1 after comment. |
anandswaminathan
approved these changes
Jun 4, 2020
max-hoffman
pushed a commit
to dolthub/flytekit
that referenced
this pull request
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Currently setting overridable matchable resources requires configuring the json for a post request which can be cumbersome - especially when auth is enabled.
For more background on matchable resource types, how they're used and how they're applied - see managing customizable resources
Type
Are all requirements met?
Complete description
Tracking Issue
flyteorg/flyte#335
Follow-up issue
NA