feat: expand/collapse domain settings section #358
Conversation
Signed-off-by: Olga Nad <[email protected]>
…o fix-bar-chart-height Signed-off-by: Olga Nad <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #358 +/- ##
==========================================
+ Coverage 65.99% 66.01% +0.01%
==========================================
Files 402 402
Lines 8952 8962 +10
Branches 1574 1579 +5
==========================================
+ Hits 5908 5916 +8
- Misses 3044 3046 +2
Continue to review full report at Codecov.
|
| @@ -69,6 +70,8 @@ describe('ProjectDashboard', () => { | |||
| [sortQueryKeys.key]: executionSortFields.createdAt, | |||
| }; | |||
|
|
|||
| jest.spyOn(LocalCache, 'useLocalCache'); | |||
There was a problem hiding this comment.
Is this needed? don't see where the function return or isCalled checked or mocked.
Looks like without it tests should also pass
There was a problem hiding this comment.
useLocalCache was added to a child component DomainSettingsSection and tests fail when parent tries to render a child
…o fix-bar-chart-height
Signed-off-by: Olga Nad <[email protected]>
| paddingLeft: theme.spacing(1), | ||
| paddingRight: theme.spacing(3), | ||
| paddingTop: theme.spacing(1), | ||
| minHeight: '135px', |
There was a problem hiding this comment.
added min height, so the chart is rendered inside the reserved space without any shifts of the content below it
# [0.50.0](http://github.com/lyft/flyteconsole/compare/v0.49.0...v0.50.0) (2022-04-08) ### Features * expand/collapse domain settings section ([#358](http://github.com/lyft/flyteconsole/issues/358)) ([fc048a6](http://github.com/lyft/flyteconsole/commit/fc048a668a89d44a3e4abd332e07274c83caa320))
|
🎉 This PR is included in version 0.50.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Signed-off-by: Olga Nad [email protected]
Type
Are all requirements met?
Complete description
BarChartcomponent to include title, so its styles are consistent across the app.BarChartcomponent used in the Timeline tab asTimelineChartto avoid confusion with the above mentioned component.Domain Settingstitle to match similar titles on the page.Tracking Issue
fixes flyteorg/flyte#356
Demos