Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register kubectl-flyte in Krew #121

Closed
kumare3 opened this issue Nov 23, 2019 · 5 comments
Closed

Register kubectl-flyte in Krew #121

kumare3 opened this issue Nov 23, 2019 · 5 comments
Assignees
@yindia
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone
0.11.0

Comments

@kumare3
Copy link
Contributor

kumare3 commented Nov 23, 2019

Krew is Kubectl plugin management system
https://github.com/kubernetes-sigs/krew-index/blob/master/plugins.md

We should deliver kubectl-flyte through Krew
@kumare3 kumare3 added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed Task labels Nov 23, 2019
@yindia
Copy link
Contributor

yindia commented Jul 5, 2020

@kumare3 I have idea about krew. can this assigned to me ?

@kumare3
Copy link
Contributor Author

kumare3 commented Jul 5, 2020

@evalsocket absolutely. Also check my previous comment, we can use the slack channel to get faster comms if interested

@kumare3
Copy link
Contributor Author

kumare3 commented Jul 5, 2020

@evalsocket kubectl-flyte is part of flytepropeller. I think the entire cmdline for flytepropeller needs a little more TLC, let me know if you want to improve it.

@yindia
Copy link
Contributor

yindia commented Jul 6, 2020 •
edited
Loading

@kumare3 I am interested?

Can we also add goreleaser for kubectl-flyte to build and publish binary with release.

@kumare3
Copy link
Contributor Author

kumare3 commented Jul 6, 2020 •
edited
Loading

@evalsocket yes we already have an issue for that. We have done it for flytestdlib. The aim is to do it for most of the repos - https://github.com/lyft/flytestdlib (where we have binaries)

Goreleaser issue.
#120

@yindia yindia mentioned this issue Jul 6, 2020
Closed
8 tasks
@yindia yindia mentioned this issue Aug 6, 2020
Merged
8 tasks
@kumare3 kumare3 added this to the 0.11.0 milestone Feb 8, 2021
@kumare3 kumare3 closed this as completed Feb 8, 2021
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@surindersinghp
[Bug Fix] Node timeout should use default value if set to zero. (flyt…
a735250 
…eorg#121)

* [Bug Fix] Node timeout should use default value if set to zero.

* .

* feedback

* cr feedback
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@honnix
Gcs remote data (flyteorg#121)
6e2c136 
* signed GCS URL

Impersonate the signingPrincipal to get object attributes and sign the GCS URL

This will make sure only the `signingPrincipal` needs readonly permission on the
object instead of the service account associated with flyteadmin.
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@katrogan
Introduce default plugin for task type (flyteorg#121)
5a41bd9
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@pingsutw
Move database config to flytestdlib (flyteorg#121)
2937b8e 
* Move db section to flytestdlib

Signed-off-by: Kevin Su <[email protected]>

* Added log level

Signed-off-by: Kevin Su <[email protected]>

* Bump gorm version

Signed-off-by: Kevin Su <[email protected]>

* Updated tests

Signed-off-by: Kevin Su <[email protected]>

* Fixed lint

Signed-off-by: Kevin Su <[email protected]>

* Addressed comment

Signed-off-by: Kevin Su <[email protected]>

* Addressed comment

Signed-off-by: Kevin Su <[email protected]>

* More tests

Signed-off-by: Kevin Su <[email protected]>

* comments

Signed-off-by: Kevin Su <[email protected]>

* rerun tests

Signed-off-by: Kevin Su <[email protected]>

* Addressed comment

Signed-off-by: Kevin Su <[email protected]>

* More tests

Signed-off-by: Kevin Su <[email protected]>

* address comment

Signed-off-by: Kevin Su <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
@surindersinghp
[Bug Fix] Node timeout should use default value if set to zero. (flyt…
56cd3ca 
…eorg#121)

* [Bug Fix] Node timeout should use default value if set to zero.

* .

* feedback

* cr feedback
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@honnix
Gcs remote data (flyteorg#121)
d9d9f52 
* signed GCS URL

Impersonate the signingPrincipal to get object attributes and sign the GCS URL

This will make sure only the `signingPrincipal` needs readonly permission on the
object instead of the service account associated with flyteadmin.
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@katrogan
Introduce default plugin for task type (flyteorg#121)
45be92a
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@pingsutw
Move database config to flytestdlib (flyteorg#121)
3acda64 
* Move db section to flytestdlib

Signed-off-by: Kevin Su <[email protected]>

* Added log level

Signed-off-by: Kevin Su <[email protected]>

* Bump gorm version

Signed-off-by: Kevin Su <[email protected]>

* Updated tests

Signed-off-by: Kevin Su <[email protected]>

* Fixed lint

Signed-off-by: Kevin Su <[email protected]>

* Addressed comment

Signed-off-by: Kevin Su <[email protected]>

* Addressed comment

Signed-off-by: Kevin Su <[email protected]>

* More tests

Signed-off-by: Kevin Su <[email protected]>

* comments

Signed-off-by: Kevin Su <[email protected]>

* rerun tests

Signed-off-by: Kevin Su <[email protected]>

* Addressed comment

Signed-off-by: Kevin Su <[email protected]>

* More tests

Signed-off-by: Kevin Su <[email protected]>

* address comment

Signed-off-by: Kevin Su <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yindia yindia

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
0.11.0
Development

No branches or pull requests
2 participants
@yindia @kumare3