Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Gorelease Added #164

Closed
wants to merge 7 commits into from
Closed

Gorelease Added #164

wants to merge 7 commits into from

Conversation

yindia
Copy link
Contributor

@yindia yindia commented Jul 6, 2020

Read then delete

TL;DR

  1. Goreleaser added for managing kubectl-flyte build and release.
  2. Github action added for releasing the binary
  3. Added version package

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

flyteorg/flyte#120

Follow-up issue

flyteorg/flyte#120

.goreleaser.yml Show resolved Hide resolved
.krew.yaml Outdated Show resolved Hide resolved
@kumare3
Copy link
Contributor

kumare3 commented Jul 6, 2020

cc @EngHabu who added goreleaser to flytestdlib

.goreleaser.yml Outdated Show resolved Hide resolved
.krew.yaml Outdated Show resolved Hide resolved
@yindia
Copy link
Contributor Author

yindia commented Jul 8, 2020

@kumare3 @EngHabu I removed krew changes from this PR. There is one constrain, for krew plugin publish we need to do it manually the first time and for creating PR in krew we need our binary in GitHub release

@yindia yindia marked this pull request as ready for review July 8, 2020 23:01
@yindia yindia requested a review from kumare3 as a code owner July 8, 2020 23:01
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2020

Codecov Report

Merging #164 into master will increase coverage by 0.30%.
The diff coverage is 100.00%.

@yindia yindia changed the title Gorelease and Krew Added Gorelease Added Jul 8, 2020
@yindia yindia requested a review from EngHabu July 9, 2020 15:09
version/version.go Outdated Show resolved Hide resolved
EngHabu
EngHabu previously approved these changes Jul 9, 2020
Copy link
Contributor

@EngHabu EngHabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you a ton!

Signed-off-by: Yuvraj <[email protected]>
@yindia yindia requested a review from EngHabu July 9, 2020 21:39
EngHabu
EngHabu previously approved these changes Jul 9, 2020
@EngHabu
Copy link
Contributor

EngHabu commented Jul 9, 2020

I'm trying to figure out the best setup to make github actions run. I understand they won't run here but I think if you merge your changes to your own master, they should (e.g. https://github.com/evalsocket/flytepropeller/compare/evalsocket:master...evalsocket:fix-121?expand=1)

You will need to set a github secret in your fork called flytegithub_repo with value evalsocket/flytepropeller to be able to build and push images to your github docker registry.

@yindia
Copy link
Contributor Author

yindia commented Aug 5, 2020

@EngHabu please review it #170

@yindia yindia closed this Aug 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants