This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yindia
commented
Jul 6, 2020
yindia
commented
Jul 6, 2020
cc @EngHabu who added goreleaser to flytestdlib |
EngHabu
reviewed
Jul 6, 2020
EngHabu
reviewed
Jul 9, 2020
EngHabu
previously approved these changes
Jul 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you a ton!
Signed-off-by: Yuvraj <[email protected]>
EngHabu
previously approved these changes
Jul 9, 2020
I'm trying to figure out the best setup to make github actions run. I understand they won't run here but I think if you merge your changes to your own master, they should (e.g. https://github.com/evalsocket/flytepropeller/compare/evalsocket:master...evalsocket:fix-121?expand=1) You will need to set a github secret in your fork called |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read then delete
TL;DR
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
flyteorg/flyte#120
Follow-up issue
flyteorg/flyte#120