krew added

[yindia]

Read then delete

TL;DR

1. Krew plugin and bot added for publish plugin

Type

• Bug Fix
• Feature
• Plugin

Are all requirements met?

• Code completed
• Smoke tested
• Unit tests added
• Code documentation added
• Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

flyteorg/flyte#121

Follow-up issue

flyteorg/flyte#121

[yindia]

We will merge this PR after our release binary is ready in github release

[codecov-commenter]

Codecov Report

Merging #173 into master will not change coverage.
The diff coverage is n/a.

[kumare3]

Looks good to me, but I cannot verify if this works :)

[yindia]

@kumare3 it will need some work

[yindia]

Krew success log. I have only one concern, Krew releases bot through an error if it's prerelease because krew doesn't allow anyone to publish their pre-release.

➜  flytepropeller git:(feature/krew) docker run -v /Users/evalsocket/workspace/golang/src/github.com/lyft/flytepropeller/.krew.yaml:/tmp/template-file.yaml rajatjindal/krew-release-bot:v0.0.38 krew-release-bot template --tag v0.5.12 --template-file /tmp/template-file.yaml
time="2020-12-10T15:13:43Z" level=info msg="getting sha256 for https://github.com/lyft/flytepropeller/releases/download/v0.5.12/kubectl-flyte_v0.5.12_darwin_x86_64.tar.gz"

time="2020-12-10T15:16:22Z" level=info msg="downloaded file /tmp/460437544/1607613223"
time="2020-12-10T15:16:22Z" level=info msg="getting sha256 for https://github.com/lyft/flytepropeller/releases/download/v0.5.12/kubectl-flyte_v0.5.12_linux_x86_64.tar.gz"

time="2020-12-10T15:18:28Z" level=info msg="downloaded file /tmp/967630695/1607613382"
apiVersion: krew.googlecontainertools.github.com/v1alpha2
kind: Plugin
metadata:
  name: flyte
spec:
  version: "v0.5.12"
  homepage: https://github.com/lyft/flyt
  shortDescription: >-
  description: |+2
      kubectl-flyte is an command line tool that can be used as an extension to kubectl.
  platforms:
    - selector:
        matchLabels:
          os: darwin
          arch: amd64
      uri: https://github.com/lyft/flytepropeller/releases/download/v0.5.12/kubectl-flyte_v0.5.12_darwin_x86_64.tar.gz
      sha256: 7ccfe0f2cda4f9ff613191f770d62338aa24ebea923c8748538fd84b11bbc7b3
      files:
        - from: kubectl-flyte
          to: ./flyte
        - from: LICENSE
          to: .
      bin: flyte
    - selector:
        matchLabels:
          os: linux
          arch: amd64
      uri: https://github.com/lyft/flytepropeller/releases/download/v0.5.12/kubectl-flyte_v0.5.12_linux_x86_64.tar.gz
      sha256: c96801b6e2ed208d4e110a34d6a5d6b3a4605fb74ce5b197e57c6f9f04f1ecc3
      files:
        - from: kubectl-flyte
          to: ./flyte
        - from: LICENSE
          to: .
      bin: flyte

[codecov-io]

Codecov Report

Merging #173 (0ab624c) into master (f2a4b79) will decrease coverage by 0.01%.
The diff coverage is n/a.

[yindia]

@EngHabu any update on this PR ?