testsuite: fix a couple intermittent test failures #4247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garlick
approved these changes
Mar 29, 2022
|
Oh, typing too fast |
|
Thanks! I fixed the typo and will set MWP |
Problem: A couple tests in `t0007-ping.t` assume short hostnames by using $(hostname -s) as an expected value. This causes failures when the domain is part of the hostname. Change uses of $(hostname -s) to just $(hostname) Fixes flux-framework#4109
Problem: t2900-job-timelimits.t has been seen to fail when flux-jobs rounds the expiration of a job differently than is in the instance R. Since we're not concerned with floating-point seconds for this particular test, be sure to round/truncate the expiration values before comparison by using the existing round() function.
Codecov Report
@@ Coverage Diff @@
## master #4247 +/- ##
==========================================
- Coverage 83.54% 83.53% -0.02%
==========================================
Files 386 386
Lines 64651 64640 -11
==========================================
- Hits 54012 53994 -18
- Misses 10639 10646 +7
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple minor test failures: