Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testsuite: fix a couple intermittent test failures #4247

Merged
merged 2 commits into from
Mar 30, 2022
Merged

testsuite: fix a couple intermittent test failures #4247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d255f4d
testsuite: t0007-ping.t: do not assume short hostnames
grondo Mar 29, 2022
e924dbc
testsuite: fix potential rounding issue in expiration test
grondo Mar 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions t/t0007-ping.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,10 +138,10 @@ test_expect_success 'ping help output works' '
'

test_expect_success 'ping works with hostname' '
flux ping --count=1 $(hostname -s)
flux ping --count=1 $(hostname)
'
test_expect_success 'ping works with hostname!service' '
flux ping --count=1 "$(hostname -s)!broker"
flux ping --count=1 "$(hostname)!broker"
'
test_expect_success 'ping fails with unknown hostname' '
test_must_fail flux ping --count=1 "notmyhost!broker"
Expand Down
3 changes: 2 additions & 1 deletion t/t2900-job-timelimits.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ test_expect_success HAVE_JQ 'job timelimits are propagated' '
id1=\$(flux mini submit --wait-event=start sleep 300)
flux jobs -no "{id.f58} {expiration}"
test "\$(flux jobs -no {expiration} \$id1)" = "\$expiration"
exp1=\$(flux jobs -no {expiration} \$id1)
test "\$(round \$exp1)" = "\$(round \${expiration})"
flux job cancelall -f
id2=\$(flux mini submit --wait-event=start -t 1m sleep 300)
Expand Down