Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ping hostname test failures #4109

Closed
grondo opened this issue Feb 7, 2022 · 1 comment
Closed

ping hostname test failures #4109

grondo opened this issue Feb 7, 2022 · 1 comment

Comments

@grondo
Copy link
Contributor

grondo commented Feb 7, 2022

In the toss buildfarm, the following ping tests are failing

expecting success: 
        flux ping --count=1 $(hostname -s)
flux-ping: builder1-x86.ping: Function not implemented
not ok 25 - ping works with hostname
expecting success: 
        flux ping --count=1 "$(hostname -s)!broker"
flux-ping: invalid nodeid/host: 'builder1-x86'
not ok 26 - ping works with hostname!service
expecting success: 
        test_must_fail flux ping --count=1 "notmyhost!broker"
flux-ping: invalid nodeid/host: 'notmyhost'

Probably just needs the same fix applied as @chu11 in
3872d40
@grondo
Copy link
Contributor Author

grondo commented Mar 5, 2022

Oops, this is still an issue for TOSS 3 builders.

@grondo grondo added this to the flux-core v0.38.0 milestone Mar 5, 2022
grondo added a commit to grondo/flux-core that referenced this issue Mar 29, 2022
@grondo
testsuite: t0007-ping.t: do not assume short hostnames
7ff9490 
Problem: A couple tests in `t0007-ping.t` assume short hostnames
by using $(hostname -s) as an expected value. This causes failures
when the domain is part of the hostname.

Change uses of $(hostname -s) to just $(hostname)

Fixes flux-framework#4109
@mergify mergify bot closed this as completed in d255f4d Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@grondo