cmd/flux-kvs: Update dir and ls usage

[chu11]

With the dir and ls commands in flux-kvs, if a user specifies a
namespace prefix without a key, assume the user desires the root
(i.e. ".") directory within that namespace.

Update/adjust unit tests appropriately.

Fixes #1434

[garlick]

Er. not sure this looks right:

$ flux kvs namespace-create foo
$ flux kvs put ns:foo/a=b
$ flux kvs dir ns:foo/
ns:foo/..a = b

[grondo]

Because you decorate with . here, is that resulting in an extra . when the keys are actually printed in dir? e.g. I'm seeing:

$ flux kvs put ns:foo/bar=none
$ flux kvs dir ns:foo/
ns:foo/..bar = none

The /.. might confusing people. I would assume we'd want the same output as we used to put the key in the first place, i.e. ns:foo/bar = none -- leading dots stripped.

[grondo]

As long as you are in here, I wonder if a fix for this issue would also fix #1391? For some reason I find this awkward:

$ flux kvs dir resource. 
resource..hwloc.

Possibly just stripping all trailing . from "key" will help?

[grondo]

Oops sorry, @garlick beat me to it.

[chu11]

Yup, that is issue #1391. I was going to fix it separately.

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@f4e0b7e). Click here to learn what that means.
The diff coverage is 93.75%.

@@            Coverage Diff            @@
##             master    #1444   +/-   ##
=========================================
  Coverage          ?   78.76%           
=========================================
  Files             ?      163           
  Lines             ?    30208           
  Branches          ?        0           
=========================================
  Hits              ?    23792           
  Misses            ?     6416           
  Partials          ?        0

Impacted Files	Coverage Δ
src/cmd/flux-kvs.c	81.26% <93.75%> (ø)

[chu11]

@garlick The double period is issue #1391, was going to fix that issue separately. But could merge in here if that's what's desired.

[garlick]

Either way. I suppose together in one pr is slightly preferable.

…

On Tue, Apr 10, 2018, 2:14 PM Al Chu ***@***.***> wrote: @garlick <https://github.com/garlick> The double period is issue #1391 <#1391>, was going to fix that issue separately. But could merge in here if that's what's desired. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1444 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKX2xb-jjdG0IGDzFltKZNwyl5ZpKVWks5tnSCbgaJpZM4TO-Cu> .

[chu11]

Just pushed update w/ period output corner case fixes. It fixes both the double period output case an an extraneous period output corner case that I found along the way. Lots of unit tests added.

Also added in dumb patch in which I remove a duplicate test.

[chu11]

hit a

PASS: t4000-issues-test-driver.t 3 - t0821-kvs-segfault.sh

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

which I think is #1311. Restarted builder.

[garlick]

Better!

$ flux kvs put ns:foo/a=b
$ flux kvs dir ns:foo/
ns:foo/a = b
$ flux kvs dir ns:foo/.
ns:foo/a = b

Hmm, what about this one?

$ flux kvs dir ns:foo/..
ns:foo/..a = b

[chu11]

I would say this is a different bug, where we have to decide if we want to "normalize" a users input before output. We didn't do that before.

>flux kvs ls -R resource......hwloc...xml
resource......hwloc...xml:
0    1    2    3

Is this a change we want to do? I think that it should be different issue though.

[chu11]

I'm going to create a new issue for the above case, as I feel its separate from this PR and has a few things to consider.

[garlick]

Sounds good. I'll go ahead and merge this. Thanks!