Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvs: user facing commands may need fine tuning for namespaces #1434

Closed
garlick opened this issue Apr 6, 2018 · 1 comment · Fixed by #1444
Closed

kvs: user facing commands may need fine tuning for namespaces #1434

garlick opened this issue Apr 6, 2018 · 1 comment · Fixed by #1444
Assignees

Comments

@garlick
Copy link
Member

garlick commented Apr 6, 2018

As noted in #1432

$ flux kvs namespace-create foo
$ flux kvs put ns
$ flux kvs put ns:foo/a=42
$ flux kvs --namespace=foo dir
a = 42
$ flux kvs dir ns:foo
flux-kvs: ns:foo: Invalid argument  ### should that work?
$ flux kvs dir ns:foo/
flux-kvs: ns:foo/: Invalid argument  ### seems like that should work
$ flux kvs dir ns:foo/.  ### seems like both double dots should not be displayed
ns:foo/..a = 42
$ flux kvs ls ns:foo/.  
ns:foo/: Invalid argument  ### that should work
$ flux kvs link  ns:foo/. linktofoo
$ flux kvs dir -R linktofoo
linktofoo.a = 42

Some of this seems a bit odd.

We should decide how flux kvs dir, flux kvs ls, etc should present to the user with namespaces thrown into the mix.

@chu11
Copy link
Member

chu11 commented Apr 10, 2018

Thinking about this, I think

flux kvs dir ns:foo/

and

flux kvs dir ns:foo/.

should do the same thing, but think

flux kvs dir ns:foo

should be an error, b/c its an improperly formatted namespace specifier.

chu11 added a commit to chu11/flux-core that referenced this issue Apr 10, 2018
With the dir and ls commands in flux-kvs, if a user specifies a
namespace prefix without a key, assume the user desires the root
(i.e. ".") directory within that namespace.

Update/adjust unit tests appropriately.

Fixes flux-framework#1434
chu11 added a commit to chu11/flux-core that referenced this issue Apr 10, 2018
With the dir and ls commands in flux-kvs, if a user specifies a
namespace prefix without a key, assume the user desires the root
(i.e. ".") directory within that namespace.

Update/adjust unit tests appropriately.

Fixes flux-framework#1434
chu11 added a commit to chu11/flux-core that referenced this issue Apr 11, 2018
With the dir and ls commands in flux-kvs, if a user specifies a
namespace prefix without a key, assume the user desires the root
(i.e. ".") directory within that namespace.

Update/adjust unit tests appropriately.

Fixes flux-framework#1434
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants