You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Unlike #1391, this is due to the fact that we don't normalize keys when we output them to the user. For example:
>flux kvs ls -R resource......hwloc...xml
resource......hwloc...xml:
0 1 2 3
"key normalization" was handled in #1182 (solving #1173 and #1180) on the server side for the purpose of parsing a user's input. But it was not handled on the client side when outputting a user's input.
Should we normalize the key before outputting? On the one hand it seems the right thing to do, as it outputs what the server side interprets. On the other hand, we're simply outputting whatever the user input. So perhaps the behavior should stay the way it is.
Or another idea, should it be an error when a non-normalized key is passed in by the user? That way there is never any confusion from the client side. Should this be handled in libkvs or is only a flux-kvs behavior?
Also, what should we consider normalized vs non-normalized? Double periods are obviously bad. But periods at the end of the key? I would lean to ok on those.
The text was updated successfully, but these errors were encountered:
idea: always normalize a key on output, but output warning to stderr saying "normalizing input to normalized"? Will require bunch of "normalize the key" calls and strcmps.
Brought up in #1444, @garlick noted:
Unlike #1391, this is due to the fact that we don't normalize keys when we output them to the user. For example:
"key normalization" was handled in #1182 (solving #1173 and #1180) on the server side for the purpose of parsing a user's input. But it was not handled on the client side when outputting a user's input.
Should we normalize the key before outputting? On the one hand it seems the right thing to do, as it outputs what the server side interprets. On the other hand, we're simply outputting whatever the user input. So perhaps the behavior should stay the way it is.
Or another idea, should it be an error when a non-normalized key is passed in by the user? That way there is never any confusion from the client side. Should this be handled in
libkvs
or is only aflux-kvs
behavior?Also, what should we consider normalized vs non-normalized? Double periods are obviously bad. But periods at the end of the key? I would lean to ok on those.
The text was updated successfully, but these errors were encountered: