Document the process and get things ready #1
Conversation
Hixie
force-pushed
the
first
branch
2 times, most recently
from
a4ca1b2 to
c717a2a
Compare
Hixie
force-pushed
the
first
branch
3 times, most recently
from
2f4abb2 to
a9da6fb
Compare
registry/DanTup_tiler.test
Outdated
| @@ -0,0 +1,7 @@ | |||
| [email protected] | |||
There was a problem hiding this comment.
oops. replaced me with dantup.
registry/template.test
Outdated
| # specific revision. You may regularly submit PRs that update the | ||
| # revision being used. | ||
| # | ||
| # Each command is run in a separate shell. |
There was a problem hiding this comment.
Specify which environment / shell. e.g. Linux / bash.
There was a problem hiding this comment.
I guess technically it's not even a shell, I just spawn the process after splitting on spaces.
| * All the code must be available publicly on GitHub under a license | ||
| compatible with this effort. | ||
|
|
||
| * Tests must be hermetic. For example, a test should not involve |
There was a problem hiding this comment.
What about the setup required to run a test (aside from cloning the repo)?
There was a problem hiding this comment.
Like downloading an Android SDK or a flutter_tools plugin (when such a thing exists)
There was a problem hiding this comment.
The Android SDK should be provided by the test environment (still working on the details of that).
Plugins should be pinned by version, I guess. Maybe we should require pubspec.lock files?
There was a problem hiding this comment.
Good point - we totally should.
Hixie
force-pushed
the
first
branch
3 times, most recently
from
e6cb073 to
050ca6e
Compare
|
Hello! Is it something that could help open source maintainers to detect breaking changes? It may be interesting to develop a bit more the description. 😄 |
|
It would help us know when we are going to break someone, yes. And let us reach out. |
|
(The bots are failing successfully in their current configuration.) |
This introduces a script that implements the conventions described in flutter/tests#1.
This introduces a script that implements the conventions described in flutter/tests#1.
This introduces a script that implements the conventions described in flutter/tests#1.
The pixel tests in the tiler suite are experiencing the same failure as is described in flutter/flutter#149934 cc @DanTup ``` | ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════ | The following assertion was thrown while running async test code: | Golden "test-maps/geometry/orthogonal_macos_arm.png": Pixel test failed, 0.00%, 8px diff detected. | Failure feedback can be found at | /Volumes/Work/s/w/ir/x/t/flutter_customer_testing.DanTup_tiler.GmgOoy/tests/test/failures | | When the exception was thrown, this was the stack: | #0 LocalFileComparator.compare (package:flutter_test/src/_goldens_io.dart:106:5) | <asynchronous suspension> | #1 MatchesGoldenFile.matchAsync.<anonymous closure> (package:flutter_test/src/_matchers_io.dart:118:32) | <asynchronous suspension> | <asynchronous suspension> | #3 _expect.<anonymous closure> (package:matcher/src/expect/expect.dart:123:26) | <asynchronous suspension> | <asynchronous suspension> | #5 expectLater.<anonymous closure> (package:flutter_test/src/widget_tester.dart:512:24) | <asynchronous suspension> | #6 expectMapRender (file:///Volumes/Work/s/w/ir/x/t/flutter_customer_testing.DanTup_tiler.GmgOoy/tests/test/utils.dart:43:5) | <asynchronous suspension> | #7 testMapRender.<anonymous closure> (file:///Volumes/Work/s/w/ir/x/t/flutter_customer_testing.DanTup_tiler.GmgOoy/tests/test/utils.dart:20:5) | <asynchronous suspension> | #8 testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:183:15) | <asynchronous suspension> | #9 TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:1025:5) | <asynchronous suspension> | <asynchronous suspension> | (elided 3 frames from dart:async and package:stack_trace) | | The exception was caught asynchronously. | ════════════════════════════════════════════════════════════════════════════════════════════════════ | | 00:05 +10 -1: geometry/orthogonal [E] | Test failed. See exception logs above. | The test description was: geometry/orthogonal | | | To run this test again: /Volumes/Work/s/w/ir/x/w/flutter/bin/cache/dart-sdk/bin/dart test /Volumes/Work/s/w/ir/x/t/flutter_customer_testing.DanTup_tiler.GmgOoy/tests/test/render_test.dart -p vm --plain-name 'geometry/orthogonal' ```
No description provided.