Add DanTup/tiler back to registry #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvolkert
approved these changes
Jul 22, 2019
|
Permissions don't let me merge this so someone else will have to (if/when you're happy with it :-)). |
zanderso
added a commit
that referenced
this pull request
Jun 7, 2024
The pixel tests in the tiler suite are experiencing the same failure as is described in flutter/flutter#149934 cc @DanTup ``` | ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════ | The following assertion was thrown while running async test code: | Golden "test-maps/geometry/orthogonal_macos_arm.png": Pixel test failed, 0.00%, 8px diff detected. | Failure feedback can be found at | /Volumes/Work/s/w/ir/x/t/flutter_customer_testing.DanTup_tiler.GmgOoy/tests/test/failures | | When the exception was thrown, this was the stack: | #0 LocalFileComparator.compare (package:flutter_test/src/_goldens_io.dart:106:5) | <asynchronous suspension> | #1 MatchesGoldenFile.matchAsync.<anonymous closure> (package:flutter_test/src/_matchers_io.dart:118:32) | <asynchronous suspension> | <asynchronous suspension> | #3 _expect.<anonymous closure> (package:matcher/src/expect/expect.dart:123:26) | <asynchronous suspension> | <asynchronous suspension> | #5 expectLater.<anonymous closure> (package:flutter_test/src/widget_tester.dart:512:24) | <asynchronous suspension> | #6 expectMapRender (file:///Volumes/Work/s/w/ir/x/t/flutter_customer_testing.DanTup_tiler.GmgOoy/tests/test/utils.dart:43:5) | <asynchronous suspension> | #7 testMapRender.<anonymous closure> (file:///Volumes/Work/s/w/ir/x/t/flutter_customer_testing.DanTup_tiler.GmgOoy/tests/test/utils.dart:20:5) | <asynchronous suspension> | #8 testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:183:15) | <asynchronous suspension> | #9 TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:1025:5) | <asynchronous suspension> | <asynchronous suspension> | (elided 3 frames from dart:async and package:stack_trace) | | The exception was caught asynchronously. | ════════════════════════════════════════════════════════════════════════════════════════════════════ | | 00:05 +10 -1: geometry/orthogonal [E] | Test failed. See exception logs above. | The test description was: geometry/orthogonal | | | To run this test again: /Volumes/Work/s/w/ir/x/w/flutter/bin/cache/dart-sdk/bin/dart test /Volumes/Work/s/w/ir/x/t/flutter_customer_testing.DanTup_tiler.GmgOoy/tests/test/render_test.dart -p vm --plain-name 'geometry/orthogonal' ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--remotefrom submodule update which seems to result in getting the latest version rather than the one specified in the parent repoI don't think these tests are flaky, but rather broke due to a change in Flutter that was then reverted. I'd updated Goldens in the meantime, which resulted in them appearing to break multiple times (and to confuse things, in PRs they could pass/fail based on the Flutter version at the time the branch was made). See more info at #8 (comment).
If we do see them flake again, feel free to drop them and I'll do more investigation though,
@tvolkert @Hixie