-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[webview_flutter_platform_interface] Updates platform interface to new interface #6846
[webview_flutter_platform_interface] Updates platform interface to new interface #6846
Conversation
See e42b9ff for a better layout of all the added files of this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 🍾 LGTM!
(I didn't review any of the source since it's just a merge of previously reviewed code; I just skimmed the file list and double-checked the metadata: pubspec, README, etc.)
@@ -8,3 +8,4 @@ | |||
|
|||
# This is a permament entry, as it should never be a direct app dependency. | |||
- plugin_platform_interface | |||
- webview_flutter_platform_interface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to update the PR and do CI again for this, but for the next round: we should put comments about why we're temporarily adding things here (with issue reference) even when we plan to almost immediately remove them again because it's easy to forget to take things back off of this list, so having a clear way to see what's an entry that we just forgot to remove is helpful.
…face to new interface (flutter/plugins#6846)
* 00b77e4cc Roll Flutter from 15af817 to 028c6e2 (13 revisions) (flutter/plugins#6843) * b2cdcb69a [camera_android_camerax] `unnecessary_parenthesis` lint fix (flutter/plugins#6841) * 3a093e49b [various] Enable avoid_print (flutter/plugins#6842) * 78de28ca2 [webview_flutter_platform_interface] Updates platform interface to new interface (flutter/plugins#6846)
…#117145) * 00b77e4cc Roll Flutter from 15af817 to 028c6e2 (13 revisions) (flutter/plugins#6843) * b2cdcb69a [camera_android_camerax] `unnecessary_parenthesis` lint fix (flutter/plugins#6841) * 3a093e49b [various] Enable avoid_print (flutter/plugins#6842) * 78de28ca2 [webview_flutter_platform_interface] Updates platform interface to new interface (flutter/plugins#6846)
…w interface (flutter#6846) * Set new interface in main * update pubspec changelog and readme * exclude from all plugins app test * delete all of platform interface * add all back to platform interface
webview_flutter_platform_interface
fromv4_webview
branch.pubspec.yaml
,CHANGELOG.md
, andREADME.md
.Part of flutter/flutter#94051
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.