This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter_platform_interface] Updates platform interface to new interface #6846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
p: webview_flutter
bparrishMines
changed the title
bparrishMines
added
the
override: allow breaking change
11 tasks
|
See e42b9ff for a better layout of all the added files of this PR |
stuartmorgan
approved these changes
Dec 15, 2022
| @@ -8,3 +8,4 @@ | |||
|
|
|||
| # This is a permament entry, as it should never be a direct app dependency. | |||
| - plugin_platform_interface | |||
| - webview_flutter_platform_interface | |||
There was a problem hiding this comment.
No need to update the PR and do CI again for this, but for the next round: we should put comments about why we're temporarily adding things here (with issue reference) even when we plan to almost immediately remove them again because it's easy to forget to take things back off of this list, so having a clear way to see what's an entry that we just forgot to remove is helpful.
bparrishMines
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 15, 2022
…face to new interface (flutter/plugins#6846)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 15, 2022
* 00b77e4cc Roll Flutter from 15af817 to 028c6e2 (13 revisions) (flutter/plugins#6843) * b2cdcb69a [camera_android_camerax] `unnecessary_parenthesis` lint fix (flutter/plugins#6841) * 3a093e49b [various] Enable avoid_print (flutter/plugins#6842) * 78de28ca2 [webview_flutter_platform_interface] Updates platform interface to new interface (flutter/plugins#6846)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…#117145) * 00b77e4cc Roll Flutter from 15af817 to 028c6e2 (13 revisions) (flutter/plugins#6843) * b2cdcb69a [camera_android_camerax] `unnecessary_parenthesis` lint fix (flutter/plugins#6841) * 3a093e49b [various] Enable avoid_print (flutter/plugins#6842) * 78de28ca2 [webview_flutter_platform_interface] Updates platform interface to new interface (flutter/plugins#6846)
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
…w interface (flutter#6846) * Set new interface in main * update pubspec changelog and readme * exclude from all plugins app test * delete all of platform interface * add all back to platform interface
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webview_flutter_platform_interfacefromv4_webviewbranch.pubspec.yaml,CHANGELOG.md, andREADME.md.Part of flutter/flutter#94051
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.