-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[various] Enable avoid_print #6842
[various] Enable avoid_print #6842
Conversation
Enables the `avoid_print` lint, and fixes violations (mostly by opting example files out of it).
Not all of these version bumps are necessary (the tooling doesn't do line-by-line analysis yet, so doesn't know when it's just changing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hopefully nobody depended on these debug prints 🤞as that would be quite silly
packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md
Outdated
Show resolved
Hide resolved
Based on the review comments, I've gone back and removed almost all of the version bumps. In some cases that means that the Example tab on pub.dev will be slightly out of sync with the actual example code in the repo until the next actual change, but it seems like the consensus is that since there are just either adding an This leaves version changes for:
|
* 00b77e4cc Roll Flutter from 15af817 to 028c6e2 (13 revisions) (flutter/plugins#6843) * b2cdcb69a [camera_android_camerax] `unnecessary_parenthesis` lint fix (flutter/plugins#6841) * 3a093e49b [various] Enable avoid_print (flutter/plugins#6842) * 78de28ca2 [webview_flutter_platform_interface] Updates platform interface to new interface (flutter/plugins#6846)
…#117145) * 00b77e4cc Roll Flutter from 15af817 to 028c6e2 (13 revisions) (flutter/plugins#6843) * b2cdcb69a [camera_android_camerax] `unnecessary_parenthesis` lint fix (flutter/plugins#6841) * 3a093e49b [various] Enable avoid_print (flutter/plugins#6842) * 78de28ca2 [webview_flutter_platform_interface] Updates platform interface to new interface (flutter/plugins#6846)
* [various] Enable avoid_print Enables the `avoid_print` lint, and fixes violations (mostly by opting example files out of it). * Version bumps * Add tooling analysis option file that was accidentally omitted * Fix typo in analysis_options found by adding tool sub-options * Revert most version bumps * Fix ios_platform_images
Enables the
avoid_print
lint, and fixes violations (mostly by opting example files out of it).Also fixes a typo in the analysis file that wasn't noticed until adding
script/tool/analysis_options.yaml
, and makes minor (test/example-only) updates to actually fix that option now that it's really enabled.Part of flutter/flutter#76229 and flutter/flutter#113764
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).