Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[google_maps_flutter_ios] iOS changes to support heatmaps #7314

Merged
merged 8 commits into from
Aug 6, 2024

Conversation

@Rexios80 Rexios80 marked this pull request as draft August 5, 2024 17:02
auto-submit bot pushed a commit that referenced this pull request Aug 5, 2024
@Rexios80 Rexios80 marked this pull request as ready for review August 5, 2024 21:03
@Rexios80 Rexios80 requested a review from stuartmorgan August 5, 2024 22:29
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit I missed earlier.

@Rexios80 Rexios80 added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 6, 2024
@auto-submit auto-submit bot merged commit c6a30bc into flutter:main Aug 6, 2024
76 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 6, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 6, 2024
flutter/packages@82e8d1e...551bde5

2024-08-06 [email protected] Manual roll Flutter from 3832823 to 1dd7141 (21 revisions) (flutter/packages#7317)
2024-08-06 [email protected] [google_maps_flutter_web] Web changes to support heatmaps (flutter/packages#7315)
2024-08-06 [email protected] [google_maps_flutter_ios] iOS changes to support heatmaps (flutter/packages#7314)
2024-08-06 [email protected] [google_maps_flutter_android] Android changes to support heatmaps (flutter/packages#7313)
2024-08-06 [email protected] [camera_web] Migrate to `package:web` (flutter/packages#7012)
2024-08-06 [email protected] [go_router_builder] Fixes readme typos and uses code excerpts. (flutter/packages#7280)
2024-08-05 [email protected] [go_router] redirect example signature fix (flutter/packages#7278)
2024-08-05 [email protected] [google_maps_flutter_platform_interface] Platform interface changes to support heatmaps (flutter/packages#7312)
2024-08-05 [email protected] [pointer_interceptor] Add performance warning on using pointer interceptor on iOS (flutter/packages#7288)
2024-08-05 [email protected] Roll Flutter from cbfb222 to 3832823 (4 revisions) (flutter/packages#7316)
2024-08-05 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.4 to 4.3.5 (flutter/packages#7308)
2024-08-05 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.annotation:annotation from 1.8.0 to 1.8.1 in /packages/image_picker/image_picker_android/android (flutter/packages#7302)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
flutter/packages@82e8d1e...551bde5

2024-08-06 [email protected] Manual roll Flutter from 3832823 to 1dd7141 (21 revisions) (flutter/packages#7317)
2024-08-06 [email protected] [google_maps_flutter_web] Web changes to support heatmaps (flutter/packages#7315)
2024-08-06 [email protected] [google_maps_flutter_ios] iOS changes to support heatmaps (flutter/packages#7314)
2024-08-06 [email protected] [google_maps_flutter_android] Android changes to support heatmaps (flutter/packages#7313)
2024-08-06 [email protected] [camera_web] Migrate to `package:web` (flutter/packages#7012)
2024-08-06 [email protected] [go_router_builder] Fixes readme typos and uses code excerpts. (flutter/packages#7280)
2024-08-05 [email protected] [go_router] redirect example signature fix (flutter/packages#7278)
2024-08-05 [email protected] [google_maps_flutter_platform_interface] Platform interface changes to support heatmaps (flutter/packages#7312)
2024-08-05 [email protected] [pointer_interceptor] Add performance warning on using pointer interceptor on iOS (flutter/packages#7288)
2024-08-05 [email protected] Roll Flutter from cbfb222 to 3832823 (4 revisions) (flutter/packages#7316)
2024-08-05 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.4 to 4.3.5 (flutter/packages#7308)
2024-08-05 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.annotation:annotation from 1.8.0 to 1.8.1 in /packages/image_picker/image_picker_android/android (flutter/packages#7302)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
flutter/packages@82e8d1e...551bde5

2024-08-06 [email protected] Manual roll Flutter from 3832823 to 1dd7141 (21 revisions) (flutter/packages#7317)
2024-08-06 [email protected] [google_maps_flutter_web] Web changes to support heatmaps (flutter/packages#7315)
2024-08-06 [email protected] [google_maps_flutter_ios] iOS changes to support heatmaps (flutter/packages#7314)
2024-08-06 [email protected] [google_maps_flutter_android] Android changes to support heatmaps (flutter/packages#7313)
2024-08-06 [email protected] [camera_web] Migrate to `package:web` (flutter/packages#7012)
2024-08-06 [email protected] [go_router_builder] Fixes readme typos and uses code excerpts. (flutter/packages#7280)
2024-08-05 [email protected] [go_router] redirect example signature fix (flutter/packages#7278)
2024-08-05 [email protected] [google_maps_flutter_platform_interface] Platform interface changes to support heatmaps (flutter/packages#7312)
2024-08-05 [email protected] [pointer_interceptor] Add performance warning on using pointer interceptor on iOS (flutter/packages#7288)
2024-08-05 [email protected] Roll Flutter from cbfb222 to 3832823 (4 revisions) (flutter/packages#7316)
2024-08-05 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.4 to 4.3.5 (flutter/packages#7308)
2024-08-05 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.annotation:annotation from 1.8.0 to 1.8.1 in /packages/image_picker/image_picker_android/android (flutter/packages#7302)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: google_maps_flutter platform-ios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants