[pointer_interceptor] Add performance warning on using pointer interceptor on iOS #7288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LouiseHsu
reviewed
Aug 2, 2024
| @@ -6,6 +6,8 @@ | |||
|
|
|||
| `PointerInterceptor` is a widget that prevents mouse events from being captured by an underlying [`HtmlElementView`](https://api.flutter.dev/flutter/widgets/HtmlElementView-class.html) in web, or an underlying [`PlatformView`](https://api.flutter.dev/flutter/widgets/PlatformViewLink-class.html) on iOS. | |||
|
|
|||
| Using multiple `PointerInterceptor` on iOS can be slow with increased memory usage, due to performance overhead of the underlying platform view. | |||
There was a problem hiding this comment.
tiny microscopic nit:
"Using multiple PointerInterceptor instances* on iOS can be slow and increases memory usage due to the performance overhead of the underlying platform view."
LouiseHsu
approved these changes
Aug 2, 2024
|
IMO this small detail in the README is important enough to warrant publishing a patch version of the package ( (I also tweaked the pre-launch checklist to reflect reality :P) |
ditman
changed the title
|
Bumped version and rephrased. |
hellohuanlin
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 6, 2024
…r interceptor on iOS (flutter/packages#7288)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 6, 2024
flutter/packages@82e8d1e...551bde5 2024-08-06 [email protected] Manual roll Flutter from 3832823 to 1dd7141 (21 revisions) (flutter/packages#7317) 2024-08-06 [email protected] [google_maps_flutter_web] Web changes to support heatmaps (flutter/packages#7315) 2024-08-06 [email protected] [google_maps_flutter_ios] iOS changes to support heatmaps (flutter/packages#7314) 2024-08-06 [email protected] [google_maps_flutter_android] Android changes to support heatmaps (flutter/packages#7313) 2024-08-06 [email protected] [camera_web] Migrate to `package:web` (flutter/packages#7012) 2024-08-06 [email protected] [go_router_builder] Fixes readme typos and uses code excerpts. (flutter/packages#7280) 2024-08-05 [email protected] [go_router] redirect example signature fix (flutter/packages#7278) 2024-08-05 [email protected] [google_maps_flutter_platform_interface] Platform interface changes to support heatmaps (flutter/packages#7312) 2024-08-05 [email protected] [pointer_interceptor] Add performance warning on using pointer interceptor on iOS (flutter/packages#7288) 2024-08-05 [email protected] Roll Flutter from cbfb222 to 3832823 (4 revisions) (flutter/packages#7316) 2024-08-05 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.4 to 4.3.5 (flutter/packages#7308) 2024-08-05 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.annotation:annotation from 1.8.0 to 1.8.1 in /packages/image_picker/image_picker_android/android (flutter/packages#7302) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
flutter/packages@82e8d1e...551bde5 2024-08-06 [email protected] Manual roll Flutter from 3832823 to 1dd7141 (21 revisions) (flutter/packages#7317) 2024-08-06 [email protected] [google_maps_flutter_web] Web changes to support heatmaps (flutter/packages#7315) 2024-08-06 [email protected] [google_maps_flutter_ios] iOS changes to support heatmaps (flutter/packages#7314) 2024-08-06 [email protected] [google_maps_flutter_android] Android changes to support heatmaps (flutter/packages#7313) 2024-08-06 [email protected] [camera_web] Migrate to `package:web` (flutter/packages#7012) 2024-08-06 [email protected] [go_router_builder] Fixes readme typos and uses code excerpts. (flutter/packages#7280) 2024-08-05 [email protected] [go_router] redirect example signature fix (flutter/packages#7278) 2024-08-05 [email protected] [google_maps_flutter_platform_interface] Platform interface changes to support heatmaps (flutter/packages#7312) 2024-08-05 [email protected] [pointer_interceptor] Add performance warning on using pointer interceptor on iOS (flutter/packages#7288) 2024-08-05 [email protected] Roll Flutter from cbfb222 to 3832823 (4 revisions) (flutter/packages#7316) 2024-08-05 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.4 to 4.3.5 (flutter/packages#7308) 2024-08-05 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.annotation:annotation from 1.8.0 to 1.8.1 in /packages/image_picker/image_picker_android/android (flutter/packages#7302) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
flutter/packages@82e8d1e...551bde5 2024-08-06 [email protected] Manual roll Flutter from 3832823 to 1dd7141 (21 revisions) (flutter/packages#7317) 2024-08-06 [email protected] [google_maps_flutter_web] Web changes to support heatmaps (flutter/packages#7315) 2024-08-06 [email protected] [google_maps_flutter_ios] iOS changes to support heatmaps (flutter/packages#7314) 2024-08-06 [email protected] [google_maps_flutter_android] Android changes to support heatmaps (flutter/packages#7313) 2024-08-06 [email protected] [camera_web] Migrate to `package:web` (flutter/packages#7012) 2024-08-06 [email protected] [go_router_builder] Fixes readme typos and uses code excerpts. (flutter/packages#7280) 2024-08-05 [email protected] [go_router] redirect example signature fix (flutter/packages#7278) 2024-08-05 [email protected] [google_maps_flutter_platform_interface] Platform interface changes to support heatmaps (flutter/packages#7312) 2024-08-05 [email protected] [pointer_interceptor] Add performance warning on using pointer interceptor on iOS (flutter/packages#7288) 2024-08-05 [email protected] Roll Flutter from cbfb222 to 3832823 (4 revisions) (flutter/packages#7316) 2024-08-05 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.4 to 4.3.5 (flutter/packages#7308) 2024-08-05 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.annotation:annotation from 1.8.0 to 1.8.1 in /packages/image_picker/image_picker_android/android (flutter/packages#7302) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add performance warning to package README on using pointer interceptor on iOS.
Issues
Fixes flutter/flutter#151535
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.