Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[google_maps_flutter_platform_interface] Platform interface changes to support heatmaps #7312

Merged
merged 8 commits into from
Aug 5, 2024
Merged

[google_maps_flutter_platform_interface] Platform interface changes to support heatmaps #7312

merged 8 commits into from
Aug 5, 2024

Conversation

Rexios80
Copy link
Member

@Rexios80 Rexios80 commented Aug 5, 2024 •
edited
Loading

@Rexios80 Rexios80 requested a review from stuartmorgan as a code owner August 5, 2024 15:53
@Rexios80 Rexios80 changed the title [google_maps_platform_interface] Platform interface changes to support heatmaps [google_maps_flutter_platform_interface] Platform interface changes to support heatmaps Aug 5, 2024
This was referenced Aug 5, 2024
Merged
Merged
Merged
@Rexios80
Copy link
Member Author

Rexios80 commented Aug 5, 2024 •
edited
Loading

@stuartmorgan How can I make the CI not do this?

Finding changed packages relative to "e411afe3fd269001295b19e71856075e624827f5"...
Rewriting references to: google_maps_flutter_platform_interface...
  Modified packages/google_maps_flutter/google_maps_flutter_android/pubspec.yaml
  Modified packages/google_maps_flutter/google_maps_flutter_android/example/pubspec.yaml
  Modified packages/google_maps_flutter/google_maps_flutter/pubspec.yaml
  Modified packages/google_maps_flutter/google_maps_flutter/example/pubspec.yaml
  Modified packages/google_maps_flutter/google_maps_flutter_ios/pubspec.yaml
  Modified packages/google_maps_flutter/google_maps_flutter_ios/example/ios14/pubspec.yaml
  Modified packages/google_maps_flutter/google_maps_flutter_ios/example/shared/maps_example_dart/pubspec.yaml
  Modified packages/google_maps_flutter/google_maps_flutter_ios/example/ios15/pubspec.yaml
  Modified packages/google_maps_flutter/google_maps_flutter_web/pubspec.yaml
  Modified packages/google_maps_flutter/google_maps_flutter_web/example/pubspec.yaml
Running for all packages that have uncommitted changes

@Rexios80
Copy link
Member Author

Rexios80 commented Aug 5, 2024

Oh this is supposed to be a breaking change isn't it

@Rexios80
Copy link
Member Author

Rexios80 commented Aug 5, 2024

Ugh that causes other CI issues. @stuartmorgan please advise on how to resolve this. I see the wiki info about platform interface breaking changes. How do we want to handle this?

@stuartmorgan
Copy link
Contributor

Sorry, I missed that in review due to diff collapsing. You don't edit any of the buildView* methods, they are legacy for this reason. The platform implementations just add heatmap support in buildViewWithConfiguration.

@Rexios80
Copy link
Member Author

Rexios80 commented Aug 5, 2024

Should those methods be marked as @Deprecated by now?

@stuartmorgan
Copy link
Contributor

Yes, you could add those here if you want.

Now that our settings for deprecation analysis have changed we add them as we go; that used to break us, so it required a second pass after everything else was updated, and we often didn't remember to do that in practice (as here).

@Rexios80
Copy link
Member Author

Rexios80 commented Aug 5, 2024

@stuartmorgan checks pass! Let's review this again.

stuartmorgan
stuartmorgan approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Two very small comment nits; no need to request another review for those changes, you can just add the autosubmit label once you upload those diffs.

...maps_flutter_platform_interface/lib/src/platform_interface/google_maps_flutter_platform.dart Outdated Show resolved Hide resolved
...maps_flutter_platform_interface/lib/src/platform_interface/google_maps_flutter_platform.dart Show resolved Hide resolved
@Rexios80 Rexios80 added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 5, 2024
@auto-submit auto-submit bot merged commit 9308857 into flutter:main Aug 5, 2024
76 checks passed
auto-submit bot pushed a commit that referenced this pull request Aug 6, 2024
@Rexios80
[google_maps_flutter_android] Android changes to support heatmaps (#7313
89d28fd 
)

Sequel to:
- #7312

Prequel to:
- #3257
auto-submit bot pushed a commit that referenced this pull request Aug 6, 2024
@Rexios80
[google_maps_flutter_ios] iOS changes to support heatmaps (#7314)
c6a30bc 
Sequel to:
- #7312

Prequel to:
- #3257
auto-submit bot pushed a commit that referenced this pull request Aug 6, 2024
@Rexios80
[google_maps_flutter_web] Web changes to support heatmaps (#7315)
57fcda0 
Sequel to:
- #7312

Prequel to:
- #3257
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 6, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 6, 2024
@engine-flutter-autoroll
9308857 [google_maps_flutter_platform_interface] Platform interface c…
5248ca2 
…hanges to support heatmaps (flutter/packages#7312)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 6, 2024
@engine-flutter-autoroll
Roll Packages from 82e8d1e to 551bde5 (12 revisions) (#152930)
06a729d 
flutter/packages@82e8d1e...551bde5

2024-08-06 [email protected] Manual roll Flutter from 3832823 to 1dd7141 (21 revisions) (flutter/packages#7317)
2024-08-06 [email protected] [google_maps_flutter_web] Web changes to support heatmaps (flutter/packages#7315)
2024-08-06 [email protected] [google_maps_flutter_ios] iOS changes to support heatmaps (flutter/packages#7314)
2024-08-06 [email protected] [google_maps_flutter_android] Android changes to support heatmaps (flutter/packages#7313)
2024-08-06 [email protected] [camera_web] Migrate to `package:web` (flutter/packages#7012)
2024-08-06 [email protected] [go_router_builder] Fixes readme typos and uses code excerpts. (flutter/packages#7280)
2024-08-05 [email protected] [go_router] redirect example signature fix (flutter/packages#7278)
2024-08-05 [email protected] [google_maps_flutter_platform_interface] Platform interface changes to support heatmaps (flutter/packages#7312)
2024-08-05 [email protected] [pointer_interceptor] Add performance warning on using pointer interceptor on iOS (flutter/packages#7288)
2024-08-05 [email protected] Roll Flutter from cbfb222 to 3832823 (4 revisions) (flutter/packages#7316)
2024-08-05 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.4 to 4.3.5 (flutter/packages#7308)
2024-08-05 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.annotation:annotation from 1.8.0 to 1.8.1 in /packages/image_picker/image_picker_android/android (flutter/packages#7302)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
@engine-flutter-autoroll @TytaniumDev
Roll Packages from 82e8d1e to 551bde5 (12 revisions) (flutter#152930)
edef360 
flutter/packages@82e8d1e...551bde5

2024-08-06 [email protected] Manual roll Flutter from 3832823 to 1dd7141 (21 revisions) (flutter/packages#7317)
2024-08-06 [email protected] [google_maps_flutter_web] Web changes to support heatmaps (flutter/packages#7315)
2024-08-06 [email protected] [google_maps_flutter_ios] iOS changes to support heatmaps (flutter/packages#7314)
2024-08-06 [email protected] [google_maps_flutter_android] Android changes to support heatmaps (flutter/packages#7313)
2024-08-06 [email protected] [camera_web] Migrate to `package:web` (flutter/packages#7012)
2024-08-06 [email protected] [go_router_builder] Fixes readme typos and uses code excerpts. (flutter/packages#7280)
2024-08-05 [email protected] [go_router] redirect example signature fix (flutter/packages#7278)
2024-08-05 [email protected] [google_maps_flutter_platform_interface] Platform interface changes to support heatmaps (flutter/packages#7312)
2024-08-05 [email protected] [pointer_interceptor] Add performance warning on using pointer interceptor on iOS (flutter/packages#7288)
2024-08-05 [email protected] Roll Flutter from cbfb222 to 3832823 (4 revisions) (flutter/packages#7316)
2024-08-05 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.4 to 4.3.5 (flutter/packages#7308)
2024-08-05 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.annotation:annotation from 1.8.0 to 1.8.1 in /packages/image_picker/image_picker_android/android (flutter/packages#7302)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@engine-flutter-autoroll @Buchimi
Roll Packages from 82e8d1e to 551bde5 (12 revisions) (flutter#152930)
d280e63 
flutter/packages@82e8d1e...551bde5

2024-08-06 [email protected] Manual roll Flutter from 3832823 to 1dd7141 (21 revisions) (flutter/packages#7317)
2024-08-06 [email protected] [google_maps_flutter_web] Web changes to support heatmaps (flutter/packages#7315)
2024-08-06 [email protected] [google_maps_flutter_ios] iOS changes to support heatmaps (flutter/packages#7314)
2024-08-06 [email protected] [google_maps_flutter_android] Android changes to support heatmaps (flutter/packages#7313)
2024-08-06 [email protected] [camera_web] Migrate to `package:web` (flutter/packages#7012)
2024-08-06 [email protected] [go_router_builder] Fixes readme typos and uses code excerpts. (flutter/packages#7280)
2024-08-05 [email protected] [go_router] redirect example signature fix (flutter/packages#7278)
2024-08-05 [email protected] [google_maps_flutter_platform_interface] Platform interface changes to support heatmaps (flutter/packages#7312)
2024-08-05 [email protected] [pointer_interceptor] Add performance warning on using pointer interceptor on iOS (flutter/packages#7288)
2024-08-05 [email protected] Roll Flutter from cbfb222 to 3832823 (4 revisions) (flutter/packages#7316)
2024-08-05 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.4 to 4.3.5 (flutter/packages#7308)
2024-08-05 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.annotation:annotation from 1.8.0 to 1.8.1 in /packages/image_picker/image_picker_android/android (flutter/packages#7302)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan stuartmorgan stuartmorgan approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: google_maps_flutter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rexios80 @stuartmorgan