Changes to nvidia.service to allow ordering on the subsequent services

[shsamkit]

Changes to nvidia.service to allow ordering on the subsequent services

When changed to oneshot, the subsequent services wiill actually wait for the nvidia.service to finish, i.e. wait for drivers to be installed. The subsequent services can be configured to wait for nvidia.service. This needs to be coupled with
RemainAfterExit=yes to ensure it doesn't get kicked-off automatically again.
Solves : flatcar/Flatcar#1136

How to use

Testing done

• Setup a new service that is After and Wants containerd.target - Make sure it stays disabled until containerd.target & nvidia.service are completed successfully - tested with a drop-in unit

[pothos]

Thanks for filing the PR

[sayanchowdhury]

Running the CI http://jenkins.infra.kinvolk.io:8080/job/container/job/packages_all_arches/2273/cldsv/

I will post the results after it completes.

[github-actions]

Build action triggered: https://github.com/flatcar/scripts/actions/runs/5769124647

[sayanchowdhury]

CI passed, @shsamkit should we move this PR to ready to review?

Also, could you squash the commits into one, and add required description into the commit description.

[shsamkit]

@sayanchowdhury, sure will do that

[shsamkit]

Is the commit message alright @sayanchowdhury ?

[sayanchowdhury]

Thanks the message looks good, Could also please create a changelog entry?

You would need to create a file eg 2023-08-05-change-nvidia-oneshot.md in the $SCRIPTS_ROOT/changelog/changes. Here a few examples to refer:

• https://github.com/flatcar/scripts/blob/main/changelog/changes/2023-05-12-coreos-cloudinit.md
• https://github.com/flatcar/scripts/blob/main/changelog/changes/2023-06-16-nvidia-drivers-525.105.17.md

[shsamkit]

on it

[shsamkit]

@sayanchowdhury thanks for your help. I think this is ready to review/merge now.

[dongsupark]

Thanks