Changes to nvidia.service to allow ordering on the subsequent services

When changed to oneshot, the subsequent services wiill actually wait for the nvidia.service to finish, i.e. wait for drivers to be installed. The subsequent services can be configured to wait for nvidia.service. This needs to be coupled with RemainAfterExit=yes to ensure it doesn't get kicked-off automatically again. Solves : flatcar/Flatcar#1136
flatcar · Aug 8, 2023 · 9249f68 · 9249f68
1 parent 254e4c7
commit 9249f68
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/changelog/changes/2023-08-08-change-nvidia-oneshot.md b/changelog/changes/2023-08-08-change-nvidia-oneshot.md
@@ -0,0 +1 @@
+- Change nvidia.service to type oneshot (from the default "simple") so the subsequent services (configured with "Requires/After") are executed after the driver installation is successfully finished (flatcar/Flatcar#1136)
diff --git a/...iner/src/third_party/coreos-overlay/x11-drivers/nvidia-drivers/files/units/nvidia.service b/...iner/src/third_party/coreos-overlay/x11-drivers/nvidia-drivers/files/units/nvidia.service
@@ -2,9 +2,11 @@
 Description=NVIDIA Configure Service
 Wants=network-online.target
 After=network-online.target
+Before=containerd.target
 
 [Service]
-Type=simple
+Type=oneshot
+RemainsAfterExit=true
 Restart=no
 Environment=PATH=/opt/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin
 ExecStart=/usr/lib/nvidia/bin/setup-nvidia
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		- Change nvidia.service to type oneshot (from the default "simple") so the subsequent services (configured with "Requires/After") are executed after the driver installation is successfully finished (flatcar/Flatcar#1136)