Make attestantio import names consistent #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## deneb #510 +/- ##
========================================
Coverage ? 34.07%
========================================
Files ? 24
Lines ? 4989
Branches ? 0
========================================
Hits ? 1700
Misses ? 3066
Partials ? 223
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
this is great, thanks! |
jtraglia
commented
Sep 4, 2023
| @@ -123,7 +123,7 @@ func NewRedisCache(prefix, redisURI, readonlyURI string) (*RedisCache, error) { | |||
|
|
|||
| prefixGetHeaderResponse: fmt.Sprintf("%s/%s:cache-gethead-response", redisPrefix, prefix), | |||
| prefixExecPayloadCapella: fmt.Sprintf("%s/%s:cache-execpayload-capella", redisPrefix, prefix), | |||
| prefixPayloadContentsDeneb: fmt.Sprintf("%s/%s:cache-payloadcontenst-deneb", redisPrefix, prefix), | |||
| prefixPayloadContentsDeneb: fmt.Sprintf("%s/%s:cache-payloadcontenst-builderApiDeneb", redisPrefix, prefix), | |||
There was a problem hiding this comment.
@metachris I was re-reviewing and noticed this. This shouldn't have been changed. Will fix in a new PR.
There was a problem hiding this comment.
Fix is here:
4 tasks
avalonche
pushed a commit
that referenced
this pull request
Sep 29, 2023
* Make attestantio import names consistent * Fix linter errors & two comments
avalonche
pushed a commit
that referenced
this pull request
Oct 31, 2023
* Make attestantio import names consistent * Fix linter errors & two comments
avalonche
pushed a commit
that referenced
this pull request
Jan 4, 2024
* Make attestantio import names consistent * Fix linter errors & two comments
avalonche
pushed a commit
that referenced
this pull request
Jan 19, 2024
* Make attestantio import names consistent * Fix linter errors & two comments
austonst
pushed a commit
to aestus-relay/mev-boost-relay
that referenced
this pull request
Jan 25, 2024
* Make attestantio import names consistent * Fix linter errors & two comments
avalonche
added a commit
that referenced
this pull request
Jan 30, 2024
* Remove bellatrix from wrapper types (#475) * Remove bellatrix from wrapper types * remove test logs * Remove get header wrapper types (#477) * Remove signed blinded beacon block wrapper (#482) * remove signed blinded beacon block wrapper type * linting * remove signed beacon block wrapper types (#483) * Remove submit block request wrapper (#485) * remove submit block request wrapper types * fix tests * fix lint * Upgrade go-boost-utils (#488) * Upgrade go-boost-utils * pr comments * remove commented out code * Add custom json marshalling for versioned structs (#493) * Add deneb signature checking for block contents * Add deneb support for type conversions * Add redis and database tests to store deneb payloads * Block submission to v3 validation endpoint * Update signed block conversions * Replace some expectCont with expectOk (#509) * Allow fork epochs to be 0 * Make attestantio import names consistent (#510) * Make attestantio import names consistent * Fix linter errors & two comments * Fix mistake in redis prefix name (#517) * Fix mistake in redis prefix for deneb * Fix typo in prefix * rebase conflicts from main * update submit block request * bug fixes * fix blob sidecar signature * ssz encode request to publish block * use v2 publish endpoint by default * go mod tidy * update relay to latest builder-specs * update go mod * fix lint and tests * switch to json encoding instead of ssz for block publishing v2 * add blob logging * address pr comments * Handle no deneb fork schedule from beacon client (#572) * backwards compatibility if no deneb schedule * Update services/api/service.go Co-authored-by: Chris Hager <[email protected]> --------- Co-authored-by: Chris Hager <[email protected]> * change specific error log to info because it's expected nowadays (#574) * Add json and ssz marshalling tests (#573) * add test vectors * linting --------- Co-authored-by: Justin Traglia <[email protected]> Co-authored-by: Chris Hager <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Rename imports for github.com/attestantio/* to be more consistent.
See the mev-boost PR (in the references section) for more details. This PR follows the same conventions.
⛱ Motivation and Context
This has been a small pet-peeve of mine for a while. Due to a lot of overlapping package names, we were required to rename some imports. This wasn't very consistent. This PR aims to make things consistent.
📚 References
✅ I have run these commands
make lint(see other PR)make test-race(see other PR)go mod tidyCONTRIBUTING.md