Make attestantio import names consistent #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## develop-deneb #560 +/- ##
=================================================
+ Coverage 68.01% 68.25% +0.23%
=================================================
Files 7 7
Lines 1282 1282
=================================================
+ Hits 872 875 +3
+ Misses 346 345 -1
+ Partials 64 62 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
avalonche
approved these changes
Aug 17, 2023
4 tasks
avalonche
pushed a commit
that referenced
this pull request
Sep 13, 2023
avalonche
pushed a commit
that referenced
this pull request
Jan 4, 2024
metachris
pushed a commit
that referenced
this pull request
Jan 11, 2024
metachris
added a commit
that referenced
this pull request
Jan 19, 2024
* add deneb path * remove redirectives * Check deneb blobs * Make attestantio import names consistent (#560) * update payload fields * Compute block root to calculate block hash * remove computing deneb hash * clean up and add tests * updated builder specs * update mev-boost to updated builder-specs * fix tests * Apply suggestions from code review Co-authored-by: Justin Traglia <[email protected]> * rebase * update go-boost-utils * address pr comments --------- Co-authored-by: Justin Traglia <[email protected]> Co-authored-by: Chris Hager <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Rename imports for
github.com/attestantio/*to be more consistent. Decided to go with camelCase instead of all lowercase just for improved readability; if there were fewer words I would have loved to make it all lowercase.go-eth2-client/specimports will be unnamed.go-eth2-client/api/v*/<spec>imports will match this style:go-eth2-client/util/<spec>imports will match this style:go-builder-clientimports will match their path names sequentially:⛱ Motivation and Context
This has been a small pet-peeve of mine for a while. Due to a lot of overlapping package names, we were required to rename some imports. This wasn't very consistent. This PR aims to make things consistent.
✅ I have run these commands
make lintmake test-racego mod tidy