Add custom json marshalling for versioned structs #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avalonche
requested review from
jtraglia,
michaelneuder and
metachris
and removed request for
michaelneuder
jtraglia
approved these changes
Aug 2, 2023
Comment on lines
+269
to
+270
| } | ||
| capella := new(capella.SubmitBlockRequest) |
There was a problem hiding this comment.
Nit: for consistency with the other funcs, please add a blank line between these two blocks.
Or delete the blank lines between these blocks of code in the other functions.
| require.NoError(t, err) | ||
| expectedJSONBytes := buffer.Bytes() | ||
|
|
||
| require.Equal(t, expectedJSONBytes, bytes.ToLower(marshalledJSONBytes)) |
There was a problem hiding this comment.
I see that bytes.ToLower is necessary because the proposer fee recipient is mixed-case (checksummed).
| return nil | ||
| } | ||
|
|
||
| capella := new(apiv1capella.SignedBlindedBeaconBlock) |
There was a problem hiding this comment.
Nit: these variables (deneb and capella) collide with package names.
I think we should fix this by renaming the packages (in a later PR).
|
|
avalonche
added a commit
that referenced
this pull request
Aug 2, 2023
avalonche
added a commit
that referenced
this pull request
Aug 15, 2023
avalonche
added a commit
that referenced
this pull request
Sep 29, 2023
avalonche
added a commit
that referenced
this pull request
Oct 31, 2023
avalonche
added a commit
that referenced
this pull request
Jan 4, 2024
avalonche
added a commit
that referenced
this pull request
Jan 19, 2024
austonst
pushed a commit
to aestus-relay/mev-boost-relay
that referenced
this pull request
Jan 25, 2024
avalonche
added a commit
that referenced
this pull request
Jan 30, 2024
* Remove bellatrix from wrapper types (#475) * Remove bellatrix from wrapper types * remove test logs * Remove get header wrapper types (#477) * Remove signed blinded beacon block wrapper (#482) * remove signed blinded beacon block wrapper type * linting * remove signed beacon block wrapper types (#483) * Remove submit block request wrapper (#485) * remove submit block request wrapper types * fix tests * fix lint * Upgrade go-boost-utils (#488) * Upgrade go-boost-utils * pr comments * remove commented out code * Add custom json marshalling for versioned structs (#493) * Add deneb signature checking for block contents * Add deneb support for type conversions * Add redis and database tests to store deneb payloads * Block submission to v3 validation endpoint * Update signed block conversions * Replace some expectCont with expectOk (#509) * Allow fork epochs to be 0 * Make attestantio import names consistent (#510) * Make attestantio import names consistent * Fix linter errors & two comments * Fix mistake in redis prefix name (#517) * Fix mistake in redis prefix for deneb * Fix typo in prefix * rebase conflicts from main * update submit block request * bug fixes * fix blob sidecar signature * ssz encode request to publish block * use v2 publish endpoint by default * go mod tidy * update relay to latest builder-specs * update go mod * fix lint and tests * switch to json encoding instead of ssz for block publishing v2 * add blob logging * address pr comments * Handle no deneb fork schedule from beacon client (#572) * backwards compatibility if no deneb schedule * Update services/api/service.go Co-authored-by: Chris Hager <[email protected]> --------- Co-authored-by: Chris Hager <[email protected]> * change specific error log to info because it's expected nowadays (#574) * Add json and ssz marshalling tests (#573) * add test vectors * linting --------- Co-authored-by: Justin Traglia <[email protected]> Co-authored-by: Chris Hager <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
The request bodies for signed beacon blocks (used to publish to the beacon block) and signed blinded beacon blocks (request body for getPayload) does not have a
"version"field and thus need custom json marshalling.The version field in the struct helps with consolidating type conversions coming in later PRs.
⛱ Motivation and Context
📚 References
✅ I have run these commands
make lintmake test-racego mod tidyCONTRIBUTING.md