Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete services that implement the new FirebaseService interface #3601

Merged
merged 18 commits into from
Aug 26, 2020

Conversation

Feiyang1
Copy link
Member

Replaces #3454 which for some reason keeps failing CI test.

@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2020

🦋 Changeset is good to go

Latest commit: a31a37e

We got this.

This PR includes changesets to release 21 packages
Name Type
@firebase/component Patch
@firebase/analytics Patch
@firebase/app Patch
@firebase/database Patch
@firebase/firestore Patch
@firebase/functions Patch
@firebase/installations Patch
@firebase/messaging Patch
@firebase/performance Patch
@firebase/remote-config Patch
@firebase/storage Patch
@firebase/app-exp Patch
@firebase/functions-exp Patch
firebase Patch
firebase-firestore-integration-test Patch
firebase-size-analysis Patch
firebase-exp Patch
@firebase/rules-unit-testing Patch
@firebase/testing Patch
firebase-namespace-integration-test Patch
firebase-messaging-integration-test Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 11, 2020

Binary Size Report

Affected SDKs

  • @firebase/component

    Type Base (6a95ae1) Head (50a702b) Diff
    browser 5.16 kB 5.36 kB +191 B (+3.7%)
    esm2017 3.90 kB 4.03 kB +129 B (+3.3%)
    main 5.16 kB 5.36 kB +191 B (+3.7%)
    module 5.05 kB 5.24 kB +194 B (+3.8%)
  • firebase

    Type Base (6a95ae1) Head (50a702b) Diff
    firebase-app.js 20.0 kB 20.2 kB +219 B (+1.1%)
    firebase-performance-standalone.es2017.js 72.2 kB 72.2 kB +98 B (+0.1%)
    firebase-performance-standalone.js 47.4 kB 47.5 kB +128 B (+0.3%)
    firebase.js 823 kB 823 kB +128 B (+0.0%)

Test Logs

@github-actions
Copy link
Contributor

github-actions bot commented Aug 20, 2020

Changeset File Check ⚠️

Warning: This PR modifies files in the following packages but they have not been included in the changeset file:

  • @firebase/app-exp
  • @firebase/app-types-exp
  • @firebase/functions-exp
  • @firebase/firestore

Make sure this was intentional.

@@ -1,4 +1,4 @@
"use strict";
'use strict';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is a pain, but I am trying not to run these generated sources through formatting to make it obvious that they are generated.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 25, 2020

Size Analysis Report

Affected Products

@firebase/app-exp

  • initializeApp

    Size

    Type Base (57739ae) Head (416d03e) Diff
    size_with_ext_deps 8.94 kB 9.00 kB +55 B (+0.6%)

@firebase/functions-exp

  • getFunctions

    Size

    Type Base (57739ae) Head (416d03e) Diff
    size 1.83 kB 1.83 kB +1 B (+0.1%)
    size_with_ext_deps 5.66 kB 5.66 kB +1 B (+0.0%)
  • httpsCallable

    Size

    Type Base (57739ae) Head (416d03e) Diff
    size 5.20 kB 5.20 kB +1 B (+0.0%)
    size_with_ext_deps 9.73 kB 9.74 kB +1 B (+0.0%)
  • useFunctionsEmulator

    Size

    Type Base (57739ae) Head (416d03e) Diff
    size 1.80 kB 1.80 kB +1 B (+0.1%)
    size_with_ext_deps 5.59 kB 5.59 kB +1 B (+0.0%)

Test Logs

@Feiyang1 Feiyang1 merged commit da1c7df into master Aug 26, 2020
@Feiyang1 Feiyang1 deleted the fei-app-exp-test branch August 26, 2020 18:47
@Feiyang1 Feiyang1 restored the fei-app-exp-test branch August 26, 2020 18:47
@Feiyang1 Feiyang1 deleted the fei-app-exp-test branch August 26, 2020 18:47
@google-oss-bot google-oss-bot mentioned this pull request Sep 8, 2020
@firebase firebase locked and limited conversation to collaborators Sep 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants