Update dependency typescript to v4 (#3669)

* Update dependency typescript to v4 * fix typescript errors Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Feiyang1 <[email protected]>
firebase · Aug 25, 2020 · 57739ae · 57739ae
1 parent 05b5606
commit 57739ae
Show file tree

Hide file tree

Showing 46 changed files with 74 additions and 42 deletions.
diff --git a/integration/firebase/package.json b/integration/firebase/package.json
@@ -23,6 +23,6 @@
     "karma-typescript": "5.1.0",
     "mocha": "7.2.0",
     "npm-run-all": "4.1.5",
-    "typescript": "3.9.7"
+    "typescript": "4.0.2"
   }
 }
diff --git a/integration/firestore/package.json b/integration/firestore/package.json
@@ -27,7 +27,7 @@
     "karma-spec-reporter": "0.0.32",
     "mocha": "7.2.0",
     "ts-loader": "8.0.3",
-    "typescript": "3.9.7",
+    "typescript": "4.0.2",
     "webpack": "4.44.1",
     "webpack-stream": "5.2.1"
   }

diff --git a/package.json b/package.json
@@ -148,7 +148,7 @@
     "ts-node": "8.10.2",
     "tslint": "6.1.3",
     "typedoc": "0.16.11",
-    "typescript": "3.9.7",
+    "typescript": "4.0.2",
     "watch": "1.0.2",
     "webpack": "4.44.1",
     "yargs": "15.4.1"

diff --git a/packages-exp/app-exp/package.json b/packages-exp/app-exp/package.json
@@ -42,7 +42,7 @@
     "rollup-plugin-json": "4.0.0",
     "rollup-plugin-replace": "2.2.0",
     "rollup-plugin-typescript2": "0.27.2",
-    "typescript": "3.9.7"
+    "typescript": "4.0.2"
   },
   "repository": {
     "directory": "packages-exp/app-exp",

diff --git a/packages-exp/app-types-exp/package.json b/packages-exp/app-types-exp/package.json
@@ -26,6 +26,6 @@
     "url": "https://github.com/firebase/firebase-js-sdk/issues"
   },
   "devDependencies": {
-    "typescript": "3.9.7"
+    "typescript": "4.0.2"
   }
 }
diff --git a/packages-exp/firebase-exp/package.json b/packages-exp/firebase-exp/package.json
@@ -51,7 +51,7 @@
     "gulp": "4.0.2",
     "gulp-sourcemaps": "2.6.5",
     "gulp-concat": "2.6.1",
-    "typescript": "3.9.7"
+    "typescript": "4.0.2"
   },
   "components": [
     "app",

diff --git a/packages-exp/functions-exp/package.json b/packages-exp/functions-exp/package.json
@@ -38,7 +38,7 @@
     "@firebase/app-exp": "0.0.800",
     "rollup": "2.26.5",
     "rollup-plugin-typescript2": "0.27.2",
-    "typescript": "3.9.7"
+    "typescript": "4.0.2"
   },
   "repository": {
     "directory": "packages/functions",

diff --git a/packages-exp/functions-types-exp/package.json b/packages-exp/functions-types-exp/package.json
@@ -26,6 +26,6 @@
     "url": "https://github.com/firebase/firebase-js-sdk/issues"
   },
   "devDependencies": {
-    "typescript": "3.9.7"
+    "typescript": "4.0.2"
   }
 }
diff --git a/packages/analytics-interop-types/package.json b/packages/analytics-interop-types/package.json
@@ -20,6 +20,6 @@
     "url": "https://github.com/firebase/firebase-js-sdk/issues"
   },
   "devDependencies": {
-    "typescript": "3.9.7"
+    "typescript": "4.0.2"
   }
 }
diff --git a/packages/analytics-types/package.json b/packages/analytics-types/package.json
@@ -20,6 +20,6 @@
     "url": "https://github.com/firebase/firebase-js-sdk/issues"
   },
   "devDependencies": {
-    "typescript": "3.9.7"
+    "typescript": "4.0.2"
   }
 }
diff --git a/packages/analytics/package.json b/packages/analytics/package.json
@@ -39,7 +39,7 @@
     "rollup-plugin-node-resolve": "5.2.0",
     "rollup-plugin-typescript2": "0.27.2",
     "rollup-plugin-uglify": "6.0.4",
-    "typescript": "3.9.7"
+    "typescript": "4.0.2"
   },
   "repository": {
     "directory": "packages/analytics",

diff --git a/packages/app-types/package.json b/packages/app-types/package.json
@@ -21,6 +21,6 @@
     "url": "https://github.com/firebase/firebase-js-sdk/issues"
   },
   "devDependencies": {
-    "typescript": "3.9.7"
+    "typescript": "4.0.2"
   }
 }
diff --git a/packages/app/package.json b/packages/app/package.json
@@ -40,7 +40,7 @@
     "rollup-plugin-json": "4.0.0",
     "rollup-plugin-replace": "2.2.0",
     "rollup-plugin-typescript2": "0.27.2",
-    "typescript": "3.9.7"
+    "typescript": "4.0.2"
   },
   "repository": {
     "directory": "packages/app",

diff --git a/packages/auth-interop-types/package.json b/packages/auth-interop-types/package.json
@@ -24,6 +24,6 @@
     "url": "https://github.com/firebase/firebase-js-sdk/issues"
   },
   "devDependencies": {
-    "typescript": "3.9.7"
+    "typescript": "4.0.2"
   }
 }
diff --git a/packages/auth-types/package.json b/packages/auth-types/package.json
@@ -24,6 +24,6 @@
     "url": "https://github.com/firebase/firebase-js-sdk/issues"
   },
   "devDependencies": {
-    "typescript": "3.9.7"
+    "typescript": "4.0.2"
   }
 }
diff --git a/packages/component/package.json b/packages/component/package.json
@@ -29,7 +29,7 @@
   "devDependencies": {
     "rollup": "2.26.5",
     "rollup-plugin-typescript2": "0.27.2",
-    "typescript": "3.9.7"
+    "typescript": "4.0.2"
   },
   "repository": {
     "directory": "packages/component",

diff --git a/packages/database-types/package.json b/packages/database-types/package.json
@@ -23,6 +23,6 @@
     "url": "https://github.com/firebase/firebase-js-sdk/issues"
   },
   "devDependencies": {
-    "typescript": "3.9.7"
+    "typescript": "4.0.2"
   }
 }
diff --git a/packages/database/package.json b/packages/database/package.json
@@ -38,7 +38,7 @@
     "@firebase/app-types": "0.6.1",
     "rollup": "2.26.5",
     "rollup-plugin-typescript2": "0.27.2",
-    "typescript": "3.9.7"
+    "typescript": "4.0.2"
   },
   "repository": {
     "directory": "packages/database",

diff --git a/packages/firebase/package.json b/packages/firebase/package.json
@@ -69,7 +69,7 @@
     "rollup-plugin-terser": "6.1.0",
     "rollup-plugin-typescript2": "0.27.2",
     "rollup-plugin-uglify": "6.0.4",
-    "typescript": "3.9.7"
+    "typescript": "4.0.2"
   },
   "typings": "index.d.ts",
   "components": [

diff --git a/packages/firestore-types/package.json b/packages/firestore-types/package.json
@@ -23,6 +23,6 @@
     "url": "https://github.com/firebase/firebase-js-sdk/issues"
   },
   "devDependencies": {
-    "typescript": "3.9.7"
+    "typescript": "4.0.2"
   }
 }
diff --git a/packages/firestore/package.json b/packages/firestore/package.json
@@ -89,7 +89,7 @@
     "rollup-plugin-terser": "6.1.0",
     "rollup-plugin-typescript2": "0.27.2",
     "ts-node": "8.10.2",
-    "typescript": "3.9.7"
+    "typescript": "4.0.2"
   },
   "repository": {
     "directory": "packages/firestore",

diff --git a/packages/firestore/test/integration/api/query.test.ts b/packages/firestore/test/integration/api/query.test.ts
@@ -706,8 +706,11 @@ apiDescribe('Queries', (persistence: boolean) => {
 
       await withTestCollection(persistence, testDocs, async coll => {
         let expected = { ...testDocs };
+        // @ts-expect-error
         delete expected.a;
+        // @ts-expect-error
         delete expected.h;
+        // @ts-expect-error
         delete expected.i;
         const snapshot = await coll.where('zip', notEqualOp, 98101).get();
         expect(toDataArray(snapshot)).to.have.deep.members(
@@ -719,8 +722,11 @@ apiDescribe('Queries', (persistence: boolean) => {
           .where('zip', notEqualOp, { code: 500 })
           .get();
         expected = { ...testDocs };
+        // @ts-expect-error
         delete expected.f;
+        // @ts-expect-error
         delete expected.h;
+        // @ts-expect-error
         delete expected.i;
         expect(toDataArray(snapshot2)).to.have.deep.members(
           Object.values(expected)
@@ -729,7 +735,9 @@ apiDescribe('Queries', (persistence: boolean) => {
         // With null.
         const snapshot3 = await coll.where('zip', notEqualOp, null).get();
         expected = { ...testDocs };
+        // @ts-expect-error
         delete expected.h;
+        // @ts-expect-error
         delete expected.i;
         expect(toDataArray(snapshot3)).to.have.deep.members(
           Object.values(expected)
@@ -738,8 +746,11 @@ apiDescribe('Queries', (persistence: boolean) => {
         // With NaN.
         const snapshot4 = await coll.where('zip', notEqualOp, Number.NaN).get();
         expected = { ...testDocs };
+        // @ts-expect-error
         delete expected.h;
+        // @ts-expect-error
         delete expected.i;
+        // @ts-expect-error
         delete expected.j;
         expect(toDataArray(snapshot4)).to.have.deep.members(
           Object.values(expected)
@@ -859,9 +870,13 @@ apiDescribe('Queries', (persistence: boolean) => {
 
       await withTestCollection(persistence, testDocs, async coll => {
         let expected = { ...testDocs };
+        // @ts-expect-error
         delete expected.a;
+        // @ts-expect-error
         delete expected.c;
+        // @ts-expect-error
         delete expected.g;
+        // @ts-expect-error
         delete expected.h;
         const snapshot = await coll
           .where('zip', notInOp, [98101, 98103, [98101, 98102]])
@@ -873,7 +888,9 @@ apiDescribe('Queries', (persistence: boolean) => {
           .where('zip', notInOp, [{ code: 500 }])
           .get();
         expected = { ...testDocs };
+        // @ts-expect-error
         delete expected.f;
+        // @ts-expect-error
         delete expected.h;
         expect(toDataArray(snapshot2)).to.deep.equal(Object.values(expected));
 
@@ -884,7 +901,9 @@ apiDescribe('Queries', (persistence: boolean) => {
         // With NaN.
         const snapshot4 = await coll.where('zip', notInOp, [Number.NaN]).get();
         expected = { ...testDocs };
+        // @ts-expect-error
         delete expected.h;
+        // @ts-expect-error
         delete expected.j;
         expect(toDataArray(snapshot4)).to.deep.equal(Object.values(expected));
 
@@ -893,8 +912,11 @@ apiDescribe('Queries', (persistence: boolean) => {
           .where('zip', notInOp, [Number.NaN, 98101])
           .get();
         expected = { ...testDocs };
+        // @ts-expect-error
         delete expected.a;
+        // @ts-expect-error
         delete expected.h;
+        // @ts-expect-error
         delete expected.j;
         expect(toDataArray(snapshot5)).to.deep.equal(Object.values(expected));
       });

diff --git a/packages/functions-types/package.json b/packages/functions-types/package.json
@@ -20,6 +20,6 @@
     "url": "https://github.com/firebase/firebase-js-sdk/issues"
   },
   "devDependencies": {
-    "typescript": "3.9.7"
+    "typescript": "4.0.2"
   }
 }
diff --git a/packages/functions/package.json b/packages/functions/package.json
@@ -33,7 +33,7 @@
     "@firebase/messaging": "0.7.0",
     "rollup": "2.26.5",
     "rollup-plugin-typescript2": "0.27.2",
-    "typescript": "3.9.7"
+    "typescript": "4.0.2"
   },
   "repository": {
     "directory": "packages/functions",

diff --git a/packages/installations-types/package.json b/packages/installations-types/package.json
@@ -23,6 +23,6 @@
     "url": "https://github.com/firebase/firebase-js-sdk/issues"
   },
   "devDependencies": {
-    "typescript": "3.9.7"
+    "typescript": "4.0.2"
   }
 }
diff --git a/packages/installations/package.json b/packages/installations/package.json
@@ -37,7 +37,7 @@
     "rollup-plugin-node-resolve": "5.2.0",
     "rollup-plugin-typescript2": "0.27.2",
     "rollup-plugin-uglify": "6.0.4",
-    "typescript": "3.9.7"
+    "typescript": "4.0.2"
   },
   "peerDependencies": {
     "@firebase/app": "0.x",

diff --git a/packages/installations/src/helpers/extract-app-config.test.ts b/packages/installations/src/helpers/extract-app-config.test.ts
@@ -38,10 +38,12 @@ describe('extractAppConfig', () => {
     expect(() => extractAppConfig(undefined as any)).to.throw(FirebaseError);
 
     let firebaseApp = getFakeApp();
+    // @ts-expect-error
     delete firebaseApp.name;
     expect(() => extractAppConfig(firebaseApp)).to.throw(FirebaseError);
 
     firebaseApp = getFakeApp();
+    // @ts-expect-error
     delete firebaseApp.options;
     expect(() => extractAppConfig(firebaseApp)).to.throw(FirebaseError);
 

diff --git a/packages/logger/package.json b/packages/logger/package.json
@@ -25,7 +25,7 @@
   "devDependencies": {
     "rollup": "2.26.5",
     "rollup-plugin-typescript2": "0.27.2",
-    "typescript": "3.9.7"
+    "typescript": "4.0.2"
   },
   "repository": {
     "directory": "packages/logger",

diff --git a/packages/messaging-types/package.json b/packages/messaging-types/package.json
@@ -23,6 +23,6 @@
     "url": "https://github.com/firebase/firebase-js-sdk/issues"
   },
   "devDependencies": {
-    "typescript": "3.9.7"
+    "typescript": "4.0.2"
   }
 }
diff --git a/packages/messaging/package.json b/packages/messaging/package.json
@@ -38,7 +38,7 @@
     "rollup": "2.26.5",
     "rollup-plugin-typescript2": "0.27.2",
     "ts-essentials": "7.0.0",
-    "typescript": "3.9.7"
+    "typescript": "4.0.2"
   },
   "repository": {
     "directory": "packages/messaging",

diff --git a/packages/messaging/src/helpers/extract-app-config.test.ts b/packages/messaging/src/helpers/extract-app-config.test.ts
@@ -42,12 +42,14 @@ describe('extractAppConfig', () => {
     ).to.throw('Missing App configuration value: "App Configuration Object"');
 
     let firebaseApp = getFakeApp();
+    // @ts-expect-error
     delete firebaseApp.options;
     expect(() => extractAppConfig(firebaseApp)).to.throw(
       'Missing App configuration value: "App Configuration Object"'
     );
 
     firebaseApp = getFakeApp();
+    // @ts-expect-error
     delete firebaseApp.name;
     expect(() => extractAppConfig(firebaseApp)).to.throw(
       'Missing App configuration value: "App Name"'

diff --git a/packages/performance-types/package.json b/packages/performance-types/package.json
@@ -12,7 +12,7 @@
     "index.d.ts"
   ],
   "devDependencies": {
-    "typescript": "3.9.7"
+    "typescript": "4.0.2"
   },
   "repository": {
     "directory": "packages/performance-types",

diff --git a/packages/performance/package.json b/packages/performance/package.json
@@ -39,7 +39,7 @@
     "rollup": "2.26.5",
     "rollup-plugin-json": "4.0.0",
     "rollup-plugin-typescript2": "0.27.2",
-    "typescript": "3.9.7"
+    "typescript": "4.0.2"
   },
   "repository": {
     "directory": "packages/performance",

diff --git a/packages/remote-config-types/package.json b/packages/remote-config-types/package.json
@@ -20,6 +20,6 @@
     "url": "https://github.com/firebase/firebase-js-sdk/issues"
   },
   "devDependencies": {
-    "typescript": "3.9.7"
+    "typescript": "4.0.2"
   }
 }
diff --git a/packages/remote-config/package.json b/packages/remote-config/package.json
@@ -38,7 +38,7 @@
     "@firebase/app": "0.6.10",
     "rollup": "2.26.5",
     "rollup-plugin-typescript2": "0.27.2",
-    "typescript": "3.9.7"
+    "typescript": "4.0.2"
   },
   "repository": {
     "directory": "packages/remote-config",