Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete services that implement the new FirebaseService interface #3454

Closed
wants to merge 2 commits into from

Conversation

Feiyang1
Copy link
Member

The new FirebaseService interface removes the INTERNAL namespace and moves the delete() method to the top level.

@changeset-bot
Copy link

changeset-bot bot commented Jul 22, 2020

🦋 Changeset is good to go

Latest commit: 63cf805

We got this.

This PR includes changesets to release 22 packages
Name Type
@firebase/component Patch
@firebase/analytics Patch
@firebase/app Patch
@firebase/database Patch
@firebase/firestore Patch
@firebase/functions Patch
@firebase/installations Patch
@firebase/messaging Patch
@firebase/performance Patch
@firebase/remote-config Patch
@firebase/storage Patch
@firebase/app-exp Patch
@firebase/functions-exp Patch
firebase Patch
firebase-exp Patch
firebase-firestore-integration-test Patch
@firebase/testing Patch
firebase-browserify-test Patch
firebase-package-typings-test Patch
firebase-messaging-selenium-test Patch
firebase-typescript-test Patch
firebase-webpack-test Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 22, 2020

Binary Size Report

Affected SDKs

  • @firebase/component

    Type Base (d4ca3da) Head (1bf875e) Diff
    browser 5.16 kB 5.29 kB +129 B (+2.5%)
    esm2017 3.90 kB 3.98 kB +84 B (+2.2%)
    main 5.16 kB 5.29 kB +129 B (+2.5%)
    module 5.05 kB 5.18 kB +132 B (+2.6%)
  • firebase

    Type Base (d4ca3da) Head (1bf875e) Diff
    firebase-app.js 20.0 kB 20.1 kB +173 B (+0.9%)
    firebase-performance-standalone.es2017.js 72.1 kB 72.2 kB +53 B (+0.1%)
    firebase-performance-standalone.js 47.4 kB 47.5 kB +82 B (+0.2%)
    firebase.js 821 kB 821 kB +82 B (+0.0%)

Test Logs

@Feiyang1 Feiyang1 closed this Aug 11, 2020
@firebase firebase locked and limited conversation to collaborators Sep 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants