Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed drag and drop #11728

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Conversation

hishitetsu
Copy link
Member

@hishitetsu hishitetsu commented Mar 15, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Partially closes Bug: Drag and drop fails when receiving app uses storage apis #10171

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    I have verified that drag-and-drop works for the following applications.

Details
I was looking at #10949 and noticed that drag and drop works in many apps by setting the data to "Shell IDList Array" only.
This still does not allow drag and drop to Notepad or XShell, but there appears to be no regression. It may be necessary to create another data manually for these applications.
Also, #10949 only works for files that actually exist on the file system, so I made other files (such as files in archives) fall back to StorageItem.

@yaira2
Copy link
Member

yaira2 commented Mar 15, 2023

Visual Studio not working seems to be a regression.

@hishitetsu
Copy link
Member Author

hishitetsu commented Mar 15, 2023

Sorry, "currently not working" means "not working in the latest preview".
This PR should allow drag and drop to Visual Studio.

@yaira2 yaira2 changed the title Fix: Fixed drag and drop partially Fix: Fixed drag and drop Mar 15, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Mar 15, 2023
@yaira2 yaira2 merged commit 9608101 into files-community:main Mar 15, 2023
@hishitetsu hishitetsu deleted the FixDragAndDrop branch March 15, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Drag and drop fails when receiving app uses storage apis
2 participants