Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issues with drag & drop from Files to other apps #10949

Merged
merged 7 commits into from
Jan 8, 2023

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Jan 7, 2023

Resolved / Related Issues
Items resolved / related issues by this PR.

This PR should solve the issues we have when dragging items from Files to other apps. This should e.g work for UWP apps, the inbox Mail app, File explorer & other win32 apps.
Note: it references System.Windows.Forms, it's not mandatory but it makes things much simpler. If this works we can worry about removing all references to it later.

Validation
How did you test these changes?

  • Built and ran the app

@yaira2
Copy link
Member

yaira2 commented Jan 7, 2023

Fixes #10171?

@yaira2 yaira2 changed the title Fix: Fix drag&drop from Files to other apps Fix: Fixed drag&drop from Files to other apps Jan 7, 2023
@yaira2 yaira2 changed the title Fix: Fixed drag&drop from Files to other apps Fix: Fixed issues with drag & drop from Files to other apps Jan 7, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jan 8, 2023
@yaira2 yaira2 merged commit f8b3fb0 into files-community:main Jan 8, 2023
@gave92 gave92 deleted the dragdrop branch January 8, 2023 07:48
@gave92
Copy link
Member Author

gave92 commented Jan 8, 2023

Mmm it looks like this fixed drag&drop to some apps (WhatsApp, Unigram, Visual Studio) but breaks others (Edge, WordPad). And both fail to drag&drop to notepad or xshell (#10171).

@yaira2
Copy link
Member

yaira2 commented Jan 10, 2023

What do we need to fix this issue?

@gave92
Copy link
Member Author

gave92 commented Jan 10, 2023

I'm stumped. Couple more things I'm gonna try but might take some time.

Best to revert this for now on stable anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants