Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Introduce the new NavigationViewItem style to Properties window #11672

Merged
merged 12 commits into from
Mar 28, 2023
Merged

Feature: Introduce the new NavigationViewItem style to Properties window #11672

merged 12 commits into from
Mar 28, 2023

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Mar 11, 2023 •
edited
Loading

Description

Part of the renovation.

Motivation and Context

Tasks

  • Change style
  • Change style to be able to display two different icon corresponding states
  • Collapse pane on smaller windows
  • Make default window size wider

Validation

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots

Default mode
image

Compact mode
image

@0x5bfa

This comment was marked as outdated.

Sign in to view
@yaira2
Copy link
Member

yaira2 commented Mar 12, 2023

VisualStates are better and less xaml overall.

@yaira2
Copy link
Member

yaira2 commented Mar 22, 2023

@onein528 now that we have a selected property in OpacityIcon, we don't need to use the VisualStates anymore.

@0x5bfa
Copy link
Member Author

0x5bfa commented Mar 22, 2023

Do you @yaira2 me try that in here PR?

@yaira2
Copy link
Member

yaira2 commented Mar 22, 2023 •
edited
Loading

I already implemented it in properties but it's missing the new styles

@0x5bfa 0x5bfa mentioned this pull request Mar 26, 2023
Merged
7 tasks
@yaira2 yaira2 changed the title Feature: Introduce the new NavigationViewItem style to also Properties window Feature: Introduce the new NavigationViewItem style to Properties window Mar 27, 2023
@yaira2 yaira2 marked this pull request as ready for review March 27, 2023 19:58
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Mar 28, 2023
@yaira2 yaira2 merged commit 8ce13fa into files-community:main Mar 28, 2023
@0x5bfa
Copy link
Member Author

0x5bfa commented Mar 28, 2023

Oh thank you

@0x5bfa 0x5bfa deleted the 5bfa/introduce-newnavviewstyle-to-propswnd branch March 28, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x5bfa @yaira2