Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Improved the code quality of the customization properties page #11848

Merged
merged 3 commits into from
Mar 27, 2023

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Mar 26, 2023

Description

I've done this before in #11421 and I reverted to avoid adding off-topic changes(although it was accepted change). But here you are again.

Motivation and Context

  • Fix UI that was created for out-dated window style
  • Improve readability and maintainability of those codes

Details of change

  • Update UI to maximize GridView.
  • Update divider to use Border instead of MenuFlyoutSeparator
  • Update divider to use DividerStrokeDefaultBrush, which is expected, instead.
  • Add Commands to the ViewModel.
  • Remove events in the View.
  • Remove event handling codes in View's code-behind.

Self-check list

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?

Screenshots

Light
image

Dark
image

@0x5bfa 0x5bfa marked this pull request as ready for review March 26, 2023 14:26
@ferrariofilippo
Copy link
Contributor

I've just found a little UI-issue related with properties (it is caused by localization and happens in preview as well). You may inlcude it in this PR.

8

@0x5bfa
Copy link
Member Author

0x5bfa commented Mar 26, 2023

This was fixed by #11672.

@0x5bfa
Copy link
Member Author

0x5bfa commented Mar 27, 2023

@yaira2 Ready for review.

@yaira2 yaira2 changed the title Fix: Fixed the UI and use the ViewModel in Costomization properties page Code Quality: Improved the code quality of the customization properties page Mar 27, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Mar 27, 2023
@yaira2 yaira2 merged commit 2d6c6dd into files-community:main Mar 27, 2023
@0x5bfa 0x5bfa deleted the 5bfa/tweak-costomization branch March 28, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants