Feature: Introduce NavigationViewItemButtonStyle to Settings dialog

[0x5bfa]

Feature: Introduce NavigationViewItemButtonStyle to Settings dialog

Description

Introducing new NavView style to Settings pages. (In another PR, to Properties pages)

Motivation and Context

Basing on a new concept style of NavigationView, I am going to make them real.

Details of changes

• Add NavigationViewButtonStyle
• Refactor SettingsDialog
• Add missing namespace 'Views' in 'Files.App.Settings'

Validation

• Built and ran the app
• Tested the changes for accessibility

Screenshots

Main style

Collapsed style

[yaira2]

Refactor SettingsDialog

Depending what you mean by this, we might want to split it into a different PR.

[yaira2]

Refactor XAML in settings pages

This should be a separate PR and should be discussed beforehand.

[0x5bfa]

Ohh messed up again. I should create new one that is limited the scope.

[yaira2]

Ohh messed up again. I should create new one that is limited the scope.

I'll review it because the work is done but keep in mind for the future 🙂

[0x5bfa]

I'm reverting some super unrelated changes

[mdtauk]

This control template should be ready for the new Icon once it rolls out fully.

And Overflow scenarios need to be considered too. I have put together a design in the Figma for this control pattern

[0x5bfa]

I'm not sure I do understand what LeftPaneOverflow style is. @mdtauk What's that?

[yaira2]

@onein528 don't worry about this, the scrollbar takes care of this scenario.

[0x5bfa]

Once this is merged, I will work on properties window as well.

[0x5bfa]

Sometimes Tests goes wrong for unobvious reasons :(

[yaira2]

Happens when there are other pipelines running at the same time.

[0x5bfa]

Now, NavViewItem has completely the same style as Button one.

[yaira2]

LGTM