Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the new details view #4643

Closed
30 of 32 tasks
winston-de opened this issue Apr 16, 2021 · 17 comments
Closed
30 of 32 tasks

Improving the new details view #4643

winston-de opened this issue Apr 16, 2021 · 17 comments

Comments

@winston-de
Copy link
Contributor

winston-de commented Apr 16, 2021

This issue is to track bugs and enhancements for the new details view. If you have any, please post them here and I'll add them.

  • Collapse status column when not in a cloud drive
  • Add recycle bin columns, and hide them when outside of the recycle bin
  • Columns aren't always collapsed after switching layout modes
  • Add empty space to the right of the last column instead of stretching
  • A11y: File/folder list is missing UIA names, faulty controltype & localizedcontroltype  #2570 (wasn't possible before with the DataGrid)
  • Add button visuals for ascending and descending sort
  • Implement horizontal scrolling
  • Remember column sizes (feature request)
  • Fix double click to rename
  • File icons are too small
  • Folder icons are cut off slightly
  • Better handling of overlapping columns
  • Reduce grid splitter width, remove element
  • Context menu sometimes fails to open because selected items is empty
  • Reimplement Fix right click item selection #4457 #4460
  • Fix columns getting squished
  • Show status column in a library with a cloud folder
  • Fix collapsed column headers not being updated when switching layout modes
  • Right click menu to collapse columns
  • Don't end rename when name text box content is right clicked
  • Add a size column
  • Add a date created column (collapsed by default?)
  • Fix crash when navigating while renaming
  • Fix sticky headers
  • Focus file list upon navigation instead of header
  • reduce width so that it doesn't horizontal scroll when the window is already large enough
  • Double clicking the header divider should fit the column to width
  • Allow tab selecting columns
  • Fix issue where columns can't be resized with keyboard only
  • Can't invoke headers with keyboard alone
  • Add option to size all columns to fit in the details layout #8384
  • Feature: Ability to reorder columns in the details layout by drag/drop #8385
@winston-de winston-de self-assigned this Apr 16, 2021
@winston-de
Copy link
Contributor Author

@yaichenbaum Yeah, that's a better idea.

@complex
Copy link

complex commented Apr 17, 2021

I'd like to be able to reorder columns, for example moving size before date.

An option to auto-size the name column (to be as wide as possible) would be nice too.

@winston-de
Copy link
Contributor Author

I'd like to be able to reorder columns, for example moving size before date.

@complex This is out of scope for this issue, as the main purpose of this issue to get get to feature parity with the DataGrid based details view. However, please feel free to create a new issue for this.

An option to auto-size the name column (to be as wide as possible) would be nice too.

Currently, the name size column is adapted to take up a certain percentage of the horizontal space available. I can definitely look into increasing that.

@beqabeqa473
Copy link

Hello.

when toggling to new details mode, screenreader starts to read contents of files and folders, but everytime folder changes focus jumps to name button instead of staying on file/folder list.

please fix that thing which makes app usage not so comfortable.

thanks.

@yaira2
Copy link
Member

yaira2 commented Apr 27, 2021

@winston-de Fyi #2963.

@gave92
Copy link
Member

gave92 commented May 30, 2021

Is the new selected item background final? With the new one I find very hard too see selected items:

image

Edit: just noticed same goes for GriView selection so not tied to this issue.

@yaira2
Copy link
Member

yaira2 commented May 30, 2021

@gave92 the new styles seem to only work on 20H2. A potential fix could be to create a custom style for older versions of Windows 10.
image

@Josh65-2201
Copy link
Member

Josh65-2201 commented May 30, 2021

The highlight/selection of a file and folder should not go pass the green line as that's were the tabs end but it end up extending pass the apps width and created a scroll bar too.
image

@BanCrash
Copy link
Contributor

@gave92 the new styles seem to only work on 20H2. A potential fix could be to create a custom style for older versions of Windows 10.
image

The new styles are only compatible with 20H2? I have installed 21H1 but still not working. Or perhaps it's necessary install something else?

@gave92
Copy link
Member

gave92 commented Jun 27, 2021

The new styles are only compatible with 21H2 not 20H2

@yaira2
Copy link
Member

yaira2 commented Jun 27, 2021

@gave92 The stable version of WinUI 2.6 seems to have disabled the new styles.

@BanCrash
Copy link
Contributor

The new styles are only compatible with 21H2 not 20H2

Oh, that explains it. Thanks!

@winston-de
Copy link
Contributor Author

@gave92 The stable version of WinUI 2.6 seems to have disabled the new styles.

I think they bumped the new styles to require an even newer build of Windows than what's been released to insiders so far. I'd guess the first Windows 11 preview will have the styles.

@Josh65-2201
Copy link
Member

Josh65-2201 commented Jul 2, 2021

I don't think the top bar shouldn't disappear when scrolling.

2021-07-02.16-19-27_Trim.mp4

@mdtauk
Copy link
Contributor

mdtauk commented Jul 2, 2021

I don't the top bar shouldn't disappear when scrolling.

2021-07-02.16-19-27_Trim.mp4

I would agree, the header should be sticky when it is visible, so when in the Details view.

@Josh65-2201
Copy link
Member

The highlight/selection of a file and folder should not go pass the green line as that's were the tabs end but it end up extending pass the apps width and created a scroll bar too.
image

The scroll bar issue has been fixed but it still extends to the full width of the screen witch makes it impossible to use the white space right click menu if the files/folders extend past the height of the window.

@yaira2
Copy link
Member

yaira2 commented Feb 16, 2022

@winston-de @gave92 thank you for all your work on this issue.

@yaira2 yaira2 closed this as completed Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants