Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix right click item selection #4457 #4460

Merged
merged 2 commits into from
Apr 9, 2021
Merged

Fix right click item selection #4457 #4460

merged 2 commits into from
Apr 9, 2021

Conversation

marcofranzen99
Copy link
Contributor

@marcofranzen99 marcofranzen99 commented Apr 5, 2021 •
edited
Loading

Resolved / Related Issues
Itemize resolved / related issues by this PR.

Details of Changes
Add details of changes here.

Validation
How did you test these changes?

  • the expected behavior as described in the ticket now occurs
5kvRcPsoYI.mp4

@yaira2 yaira2 requested a review from gave92 April 5, 2021 17:30
@yaira2 yaira2 requested review from tsvietOK and removed request for gave92 April 6, 2021 19:02
@yaira2
Copy link
Member

yaira2 commented Apr 8, 2021

@mafra99 Can you resovle the merge conflicts?

@marcofranzen99
Merge remote-tracking branch 'main' into RightClickItemSelection
4268bda 
# Conflicts:
#	Files/Views/LayoutModes/GenericFileBrowser.xaml.cs
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Apr 9, 2021
@yaira2
Copy link
Member

yaira2 commented Apr 9, 2021

@mafra99 Thanks!

@yaira2 yaira2 merged commit 3a5e6c4 into files-community:main Apr 9, 2021
@marcofranzen99 marcofranzen99 deleted the RightClickItemSelection branch April 10, 2021 10:54
@yaira2 yaira2 mentioned this pull request Apr 16, 2021
Closed
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

@tsvietOK tsvietOK Awaiting requested review from tsvietOK

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcofranzen99 @yaira2