Details view improvements

[gave92]

Resolved / Related Issues
Items resolved / related issues by this PR.

• For Improving the new details view #4643

Details of Changes
Add details of changes here.

• Removed unused RectangleSelection_DataGrid, CustomDataGridStyle classes
• Added sort direction indicators to column headers
• Added size and date created columns
• Fixed an issue with details view icon column width

Validation
How did you test these changes?

• Built and ran the app

[yaira2]

@gave92 It looks like the icon column is too wide now.

[gave92]

Should be same as before: 44px

[yaira2]

@gave92 I think there is some extra padding already there because so it's not needed.

[gave92]

@yaichenbaum could you check the new icon column width? I've changed it back to 24px, but looks kinda cramped. Nevermind I think I've messed up some paddings.

[yaira2]

@yaichenbaum could you check the new icon column width? I've changed it back to 24px, but looks kinda cramped. Nevermind I think I've messed up some paddings.

You can add a fixed width to the icon content so that it doesn't shift after the content is loaded.

[gave92]

I hate UIs, could you figure out how to make it stop moving when the folder is empty? I've reverted my changes.

[yaira2]

I hate UIs, could you figure out how to make it stop moving when the folder is empty?

I can try. By the way, can we allow sorting by sync status?

[gave92]

Probably but it was never implemented.. next PR :) Disabled button in sync status looks bad, but if we're going to allow sorting by status it's not an issue. Added to todo list in #4643.

[yaira2]

Probably but it was never implemented.. next PR :) Disabled button in sync status looks bad, but if we're going to allow sorting by status it's not an issue.

Sounds good to me, File Explorer allows sorting by status so we might as well.

[yaira2]

@gave92 Can you unload the sort icon when it's not being used? It's causing the text to be trimmed when it shouldn't be.

[yaira2]

@gave92 I found the cause of the header shifting. It shifts because the header width depends on the size of all the column combined. When the user changes the directory to a directory with a different number of columns, the header needs to recalculate the correct width causing it to shift. I don't have any ideas on how to solve this right now.

[gave92]

Mmm not sure that's the same issue: what I see is that all columns shift to the left 12px if the folder is empty. Anyway can be fixed next.

[yaira2]

Great work! LGTM