Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken sticky header in details view #5396

Merged
merged 10 commits into from
Jul 12, 2021
Merged

Fix broken sticky header in details view #5396

merged 10 commits into from
Jul 12, 2021

Conversation

winston-de
Copy link
Contributor

@winston-de winston-de commented Jul 10, 2021 •
edited
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Fix issue where the header wouldn't always show when scrolling vertically
  • Update header buttons to use winui 2.6 styling
  • Update column sizes when the view area is resized

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)

@yaira2 yaira2 self-requested a review July 11, 2021 02:19
@yaira2
Copy link
Member

yaira2 commented Jul 11, 2021

@winston-de It looks like the header has an alignment issue in this PR.
image

@winston-de
Copy link
Contributor Author

Thanks, this should be fixed now.

@yaira2
Copy link
Member

yaira2 commented Jul 12, 2021

@winston-de Now it looks like there is a little too much space for the icon column.

@files-community files-community deleted a comment from winston-de Jul 12, 2021
yaira2
yaira2 approved these changes Jul 12, 2021
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jul 12, 2021
@yaira2 yaira2 merged commit 4514005 into main Jul 12, 2021
@yaira2 yaira2 mentioned this pull request Jul 12, 2021
Closed
@winston-de winston-de deleted the dvscrollfix branch July 12, 2021 04:22
@gave92 gave92 mentioned this pull request Jul 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

the bottom scrollbar almost hides the last file n the detail view
2 participants
@winston-de @yaira2