fix: not omitting result when empty #103
Conversation
|
Seems like |
|
@Wondertan It does not have the same effect unfortunately - that was my first solution but it still violates the spec: This member is REQUIRED on success. It must exist on success (if error is not empty), even if the value is null. And on error, it is not allowed to exist when the value is null (this is the case that breaks your proposal). This is what I mean in the PR description |
| // Result field MUST NOT exist if there was an error invoking the method. | ||
| // Result field is REQUIRED on success. |
There was a problem hiding this comment.
Doc nit: add a line that this is from specs
There was a problem hiding this comment.
Hey, sorry for taking so long to get to this.
Generally this direction looks good, but there's either a serious perf regression here or something is subtly wrong somewhere - this PR makes my tests hang, go test -count=1 -v ./... has now been running for a few mitutes with no signs of finishing, and they do pass in a few seconds on master.
|
Fixed version of this was now merged in #107 |
Closes #102
A MarshalJSON method is required because the omitempty is conditional - if result could be set if error exists, the diff would only be changing the tag on the struct.