fix: make resp result/error conformant to spec

[LesnyRumcajs]

Closes #102

This is a more verbose version of #103, mainly because my Go-Fu is too weak to find the issue in that code that causes timeouts. Are there any performance regressions with this? How can I check it?

It works fine on almost latest master, was 5c010e6 a regression @magik6k?

❯ go test -count=1 -v ./... | tail
--- PASS: TestReverseCallDroppedConn (1.10s)
=== RUN   TestBigResult
    rpc_test.go:1607: skipping test due to requiced resources, set I_HAVE_A_LOT_OF_MEMORY_AND_TIME=1 to run
--- SKIP: TestBigResult (0.00s)
PASS
ok      github.com/filecoin-project/go-jsonrpc  7.408s
=== RUN   TestReaderProxy
--- PASS: TestReaderProxy (0.00s)
PASS
ok      github.com/filecoin-project/go-jsonrpc/httpio   0.352s

[rvagg]

Yes, it was a regression. I've opened an alternative at #108 which should deal with the original reported problem and let through jsonrpc native errors.

[rvagg]

I think the original regression was noted with the length of time it takes to run tests, so:

On #108 so that it actually passes:

$ time go test ./... -count 1
?       github.com/filecoin-project/go-jsonrpc/auth     [no test files]
?       github.com/filecoin-project/go-jsonrpc/metrics  [no test files]
ok      github.com/filecoin-project/go-jsonrpc  6.771s
ok      github.com/filecoin-project/go-jsonrpc/httpio   0.004s

real    0m7.092s
user    0m4.143s
sys     0m2.457s

And on your branch, with #108 cherry-picked:

$ time go test ./... -count 1
?       github.com/filecoin-project/go-jsonrpc/auth     [no test files]
?       github.com/filecoin-project/go-jsonrpc/metrics  [no test files]
ok      github.com/filecoin-project/go-jsonrpc  6.785s
ok      github.com/filecoin-project/go-jsonrpc/httpio   0.004s

real    0m7.094s
user    0m4.051s
sys     0m2.514s

That looks pretty consistent to me.

[rvagg]

this seems OK to me; an alternative, more terse form might be:

func (r response) MarshalJSON() ([]byte, error) {
	data := make(map[string]interface{})
	data["jsonrpc"] = r.Jsonrpc
	data["id"] = r.ID
	if r.Error != nil {
		data["error"] = r.Error
	} else {
		data["result"] = r.Result
	}
	return json.Marshal(data)
}

[LesnyRumcajs]

this seems OK to me; an alternative, more terse form might be:

func (r response) MarshalJSON() ([]byte, error) {
	data := make(map[string]interface{})
	data["jsonrpc"] = r.Jsonrpc
	data["id"] = r.ID
	if r.Error != nil {
		data["error"] = r.Error
	} else {
		data["result"] = r.Result
	}
	return json.Marshal(data)
}

Less explicit, but more readable, I like it. Changed and co-authored you. Thanks!

[magik6k]

Looks good, and tests appear to be happy with the latest master. Thanks!