Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

share.SharesAvailable can not be called from other JSON RPC frameworks due to a bug in go-jsonrpc #2460

Open
oblique opened this issue Jul 12, 2023 · 4 comments
Labels
bug Something isn't working external Issues created by non node team members

Comments

@oblique
Copy link
Contributor

oblique commented Jul 12, 2023

Celestia Node version

eaa5835

OS

Linux

Install tools

No response

Others

No response

Steps to reproduce it

Call share.SharesAvailable form JSON RPC clients other than go-jsonrpc. In our case we used jsonrpsee.

Expected result

A response that has result or error field.

Actual result

Server responds with {"jsonrpc":"2.0","id":1}, which is causing deserialization issues on the client side.

Relevant log output

No response

Notes

This is a bug in go-jsonrpc, but reported too here for tracking. Check filecoin-project/go-jsonrpc#102

@oblique oblique added the bug Something isn't working label Jul 12, 2023
@github-actions github-actions bot added the external Issues created by non node team members label Jul 12, 2023
@Wondertan
Copy link
Member

@oblique is this the case?

@oblique
Copy link
Contributor Author

oblique commented Sep 22, 2023

If you ask if it's related to filecoin-project/go-jsonrpc#103, then yes

@zvolin
Copy link

zvolin commented May 8, 2024

@Wondertan go-jsonrpc just merged a fix for this, I think this can be closed after updating dependencies

@zvolin
Copy link

zvolin commented May 8, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working external Issues created by non node team members
Projects
None yet
Development

No branches or pull requests

4 participants
@oblique @Wondertan @zvolin and others