Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes #523

Merged
merged 18 commits into from
Sep 14, 2022
Merged

Bugfixes #523

merged 18 commits into from
Sep 14, 2022

Conversation

RemDelaporteMathurin
Copy link
Collaborator

@RemDelaporteMathurin RemDelaporteMathurin commented Sep 14, 2022

Proposed changes

Fixes #462, #454 #457

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #523 (71ccb00) into main (13232e5) will decrease coverage by 0.00%.
The diff coverage is 98.10%.

@@            Coverage Diff             @@
##             main     #523      +/-   ##
==========================================
- Coverage   98.80%   98.80%   -0.01%     
==========================================
  Files          54       54              
  Lines        2007     2001       -6     
==========================================
- Hits         1983     1977       -6     
  Misses         24       24              
Impacted Files Coverage Δ
festim/__init__.py 97.10% <ø> (ø)
festim/concentration/concentration.py 100.00% <ø> (ø)
festim/exports/export.py 100.00% <ø> (ø)
festim/initial_condition.py 87.50% <ø> (ø)
festim/sources/source.py 100.00% <ø> (ø)
festim/stepsize.py 100.00% <ø> (ø)
festim/temperature/temperature.py 100.00% <ø> (ø)
festim/h_transport_problem.py 93.25% <62.50%> (ø)
festim/temperature/temperature_solver.py 98.19% <98.19%> (ø)
festim/boundary_conditions/boundary_condition.py 100.00% <100.00%> (ø)
... and 44 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@RemDelaporteMathurin RemDelaporteMathurin merged commit c753f25 into main Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] dirichlet bc doesnt accept strings for field
1 participant