Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Henry solubillity with traps #522

Merged
merged 4 commits into from
Sep 14, 2022
Merged

Henry solubillity with traps #522

merged 4 commits into from
Sep 14, 2022

Conversation

RemDelaporteMathurin
Copy link
Collaborator

@RemDelaporteMathurin RemDelaporteMathurin commented Sep 14, 2022

Proposed changes

Fixes #454 by adding a NonImplementedError when chemical potential with Henry law is set with traps.
The solver doesn't converge when using c = theta ** 2 * S for some reason...

Another good argument for using a discontinuity instead of this variable change!!!

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@RemDelaporteMathurin RemDelaporteMathurin linked an issue Sep 14, 2022 that may be closed by this pull request
@RemDelaporteMathurin RemDelaporteMathurin merged commit fcd3ee7 into dev Sep 14, 2022
@RemDelaporteMathurin RemDelaporteMathurin deleted the patch_454 branch September 14, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Trap formulation doesn't support Henry's law
1 participant