Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Trap formulation doesn't support Henry's law #454

Closed
RemDelaporteMathurin opened this issue Apr 12, 2022 · 1 comment · Fixed by #522
Closed

[BUG] Trap formulation doesn't support Henry's law #454

RemDelaporteMathurin opened this issue Apr 12, 2022 · 1 comment · Fixed by #522
Labels
bug Something isn't working

Comments

@RemDelaporteMathurin
Copy link
Collaborator

RemDelaporteMathurin commented Apr 12, 2022 •
edited
Loading

Describe the bug
https://github.com/RemDelaporteMathurin/FESTIM/blob/305714fa16a973e327e5a17e7225627e7bb5b14c/FESTIM/concentration/traps/trap.py#L175-L180

This should be fixed!!
@RemDelaporteMathurin RemDelaporteMathurin added the bug Something isn't working label Apr 12, 2022
@RemDelaporteMathurin
Copy link
Collaborator Author

RemDelaporteMathurin commented Apr 12, 2022 •
edited
Loading

the Mobile.get_concentration_for_a_given_material() method can be used here avoiding to pass chemical_pot to Trap.create_form()

Merged
10 tasks
@RemDelaporteMathurin RemDelaporteMathurin linked a pull request Sep 14, 2022 that will close this issue
Henry solubillity with traps #522
Merged
10 tasks
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

patch_454 festim-dev/FESTIM
Henry solubillity with traps festim-dev/FESTIM
1 participant
@RemDelaporteMathurin