Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add {imagesprefix} to env-github to display images in github #144

Open
prudhomm opened this issue Oct 13, 2022 · 0 comments
Open

Add {imagesprefix} to env-github to display images in github #144

prudhomm opened this issue Oct 13, 2022 · 0 comments
Assignees
@prudhomm @lberti @jobinhio
Labels
domain:case Define a Toolbox case, be it an example or a benchmark toolboxes Impacts all toolboxes

Comments

@prudhomm
Copy link
Member

in most examples images are not shown in github because the path information is not known to github

to fix this we need to

  1. add imagesprefix definition at toplevel of .adoc file
  2. use {imagesprefix} in image::{imagesprefix}... (Note that there must be no / after {imagesprefix} otherwise it will break antora build

see #139 for an example
@prudhomm prudhomm added toolboxes Impacts all toolboxes domain:case Define a Toolbox case, be it an example or a benchmark labels Oct 13, 2022
@prudhomm prudhomm added this to Feel++ Oct 13, 2022
@prudhomm prudhomm moved this to Backlog in Feel++ Oct 13, 2022
jobinhio added a commit that referenced this issue Oct 13, 2022
@jobinhio
add imagesprefix support as described in #144
ae77d76
jobinhio added a commit that referenced this issue Oct 13, 2022
@jobinhio
add imagesprefix support for #138 as described in #144
5e5631f
jobinhio added a commit that referenced this issue Oct 14, 2022
@jobinhio
add imagesprefix support for #141 as described in #144
55d9146
prudhomm pushed a commit that referenced this issue Oct 14, 2022
@jobinhio
update suspension #138 (#143)
1b4ce37 
* update suspension #138

* add report from solid toolbox #136

* add imagesprefix support as described in #144

* add authors to metadata #145

* add imagesprefix support for #138 as described in #144

* add link to the simulation report and rename file
jobinhio added a commit that referenced this issue Oct 21, 2022
@jobinhio
add imagesprefix support for #146 as described in #144
269699c
jobinhio added a commit that referenced this issue Oct 21, 2022
@jobinhio
add imagesprefix support for #147 as described in #144
08f8a98
jobinhio added a commit that referenced this issue Nov 4, 2022
@jobinhio
add imagesprefix support for #152 as described in #144
fc01718
jobinhio added a commit that referenced this issue Nov 4, 2022
@jobinhio
add imagesprefix support for #153 as described in #144
ac3d079
prudhomm pushed a commit that referenced this issue Nov 7, 2022
@jobinhio
update spring #141 (#142)
ff9dd79 
* update spring #141

* update string #141 and add  authors' names #145

* add imagesprefix support for #141 as described in #144

* add report from solid toolbox #136
prudhomm pushed a commit that referenced this issue Nov 7, 2022
@jobinhio
146 solid pendulum study (#148)
ad06ccb 
* update pendulum #146

* add report from solid toolbox #136

* add imagesprefix support for #146 as described in #144
prudhomm pushed a commit that referenced this issue Nov 7, 2022
@jobinhio
147 solid vierendeel study (#149)
e27ab9b 
* update vierendeel  #147

* add report from solid toolbox #136

* add imagesprefix support for #147 as described in #144
jobinhio added a commit that referenced this issue Dec 9, 2022
@jobinhio
add report and imagesprefix as described in #144
a10072e
jobinhio added a commit that referenced this issue Dec 9, 2022
@jobinhio
add report and imagesprefix as described in #144
189271c
prudhomm pushed a commit that referenced this issue Mar 22, 2023
@jobinhio
152 turekkhron study (#154)
9dad30e 
* update TureKhron #152

* add report from heatfluid toolbox #136

* add imagesprefix support for #152 as described in #144
prudhomm pushed a commit that referenced this issue Mar 22, 2023
@jobinhio
153 pipestoskesmass study (#155)
ec0cfac 
* update pipestokesmass #153

* add report from heatfluid toolbox #136

* add imagesprefix support for #153 as described in #144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prudhomm prudhomm

@lberti lberti

@jobinhio jobinhio

Labels
domain:case Define a Toolbox case, be it an example or a benchmark toolboxes Impacts all toolboxes
Projects
Feel++
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@prudhomm @lberti @jobinhio