update spring #141 #142
Merged
update spring #141 #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jobinhio
commented
Oct 13, 2022
jobinhio
commented
- Have you checked to ensure there aren't other open Pull Requests for the same change?
- Have you fixed a Bug ?
- Have you added the documentation of the example or benchmark ?
- Have you successfully run the example or benchmark?
- Have you documented the results?
- Have you added the images to the documentation?
- Have you added the vtkjs files for 3D visualization in the documentation?
- Have you added the vtkjs files to a Data Management Plateform e.g https://girder.math.unistra.fr
Closed
prudhomm
added
toolbox:csm
prudhomm
requested changes
Oct 13, 2022
There was a problem hiding this comment.
- the report of the simulation is missing as well as the note regarding the report in the documentation see add toolbox report to testcase #136
- add imagesprefix support as described in Add {imagesprefix} to env-github to display images in github #144
- add authors to metadata Use github login to identify authors #145
| "Metadata": | ||
| { | ||
| "version": "1", | ||
| "author": [""], |
|
here are the results of displacement solid. here are the results of von mises criterion. |
prudhomm
approved these changes
Nov 7, 2022
| @@ -25,6 +27,7 @@ Copy case option to clipboard | |||
| </button> | |||
| ++++ | |||
|
|
|||
| NOTE: The report of the execution of the command above is available xref:spring/solid-informations.adoc[here]. | |||
There was a problem hiding this comment.
informations -> information (rename the adoc file)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.