Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update suspension #138 #143

Merged
merged 6 commits into from
Oct 14, 2022
Merged

update suspension #138 #143

merged 6 commits into from
Oct 14, 2022

Conversation

jobinhio
Copy link
Collaborator

@jobinhio jobinhio commented Oct 13, 2022

  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you fixed a Bug ?
  • Have you added the documentation of the example or benchmark ?
  • Have you successfully run the example or benchmark?
  • Have you documented the results?
  • Have you added the images to the documentation?
  • Have you added the vtkjs files for 3D visualization in the documentation?
  • Have you added the vtkjs files to a Data Management Plateform e.g https://girder.math.unistra.fr

@jobinhio jobinhio linked an issue Oct 13, 2022 that may be closed by this pull request
@prudhomm prudhomm self-requested a review October 13, 2022 09:10
@prudhomm prudhomm added toolbox:csm Toolbox CSM toolbox:heat Toolbox Heat domain:case Define a Toolbox case, be it an example or a benchmark and removed toolbox:heat Toolbox Heat labels Oct 13, 2022
Copy link
Member

@prudhomm prudhomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prudhomm prudhomm self-requested a review October 13, 2022 09:17
Copy link
Member

@prudhomm prudhomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Metadata":
{
"version": "1",
"author": [""],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add authors: see #145

@prudhomm
Copy link
Member

@jobinhio the file solid.informations.adoc needs to be renamed solid-informations.adoc. Antora interprets the first . as a separator for extentions

/cc @vincentchabannes

@prudhomm
Copy link
Member

@jobinhio you need to add the note regarding the link to the simulation report

@@ -5,7 +5,7 @@
"Metadata":
{
"version": "1",
"author": [""],
"author": ["vincentchabannes","prudhomm","lberti","jobinhio"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jobinhio you need to check the people who contributed to the testcase

@prudhomm prudhomm merged commit 1b4ce37 into master Oct 14, 2022
@prudhomm prudhomm deleted the 138-solid-suspension-study branch October 14, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:case Define a Toolbox case, be it an example or a benchmark toolbox:csm Toolbox CSM
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

solid suspension study
2 participants