-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update suspension #138 #143
Conversation
jobinhio
commented
Oct 13, 2022
•
edited
Loading
edited
- Have you checked to ensure there aren't other open Pull Requests for the same change?
- Have you fixed a Bug ?
- Have you added the documentation of the example or benchmark ?
- Have you successfully run the example or benchmark?
- Have you documented the results?
- Have you added the images to the documentation?
- Have you added the vtkjs files for 3D visualization in the documentation?
- Have you added the vtkjs files to a Data Management Plateform e.g https://girder.math.unistra.fr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- the report of the simulation is missing as well as the note regarding the report in the documentation see add toolbox report to testcase #136
- add imagesprefix support as described in Add {imagesprefix} to env-github to display images in github #144
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- the report of the simulation is missing as well as the note regarding the report in the documentation see add toolbox report to testcase #136
- add imagesprefix support as described in Add {imagesprefix} to env-github to display images in github #144
- add authors to metadata Use github login to identify authors #145
"Metadata": | ||
{ | ||
"version": "1", | ||
"author": [""], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add authors: see #145
@jobinhio the file solid.informations.adoc needs to be renamed solid-informations.adoc. Antora interprets the first |
@jobinhio you need to add the note regarding the link to the simulation report |
@@ -5,7 +5,7 @@ | |||
"Metadata": | |||
{ | |||
"version": "1", | |||
"author": [""], | |||
"author": ["vincentchabannes","prudhomm","lberti","jobinhio"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jobinhio you need to check the people who contributed to the testcase