Fixed stellarphot so it can run under current astropy (and numpy, when including previous PR) #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utput generated by to astropy.modelling.model_to_fit_params which was not in a simple form when we then passed it to scipy.optimize.leastsq).
…ent version) call.
Co-authored-by: Matt Craig <[email protected]>
Co-authored-by: Matt Craig <[email protected]>
Co-authored-by: Matt Craig <[email protected]>
mwcraig
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the problem with running under astropy >5.0 (turns out it was a output generated by to
astropy.modelling.model_to_fit_paramswhich was not in a simple form that could be converted into a flatten array after being passed it toscipy.optimize.leastsq). Fixed by flattening the structure before passing it in. Also updated the documentation and environment setup to reflect no longer need to be limited to astropy 5.0.Code has also been updated in several places to properly handle use of the release version of astrowidgets (currently 0.3.0) instead of the development version.
Closes #91