-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shift-click not working on seeing_profile and tabs not displaying properly #93
Comments
Screenshot showing the screen on my Mac running Jupyter Lab in Brave (a Chromium based browser) I also confirmed that the same behavior is seen in a clean install version of Google Chrome. |
After a bit of exploration with an environment similar to the one on jupyer3 server and then updating libraries, I finally discovered what BROKE the tabs is updating jupyterlab to 4.0.1 (which updated jupyter_server to 2.6.0)! I confirmed that the following conda environment, which has everything up to date EXCEPT
This suggests that unfortunately the tab-display problem is probably due to how one of the widget libraries (likely either |
With regards to the shift-click issue, this was due to the code trying to use an unreleased version of astrowidgets. This was fixed with pull request [#92]. The tabs not rendering properly turned out to be an issue with ipywidgets running in JupyterLab >=4. I reported this as an issue to JupyterWidgets a week ago. Looks like today Andy Maloney and Martin Renou at JupyterWidgets have figured out the issue with tabs and resolved it with JupyterLab PR #3787. |
Fixed in ipywidgets 8.0.7 |
The current version of the code from GitHub (pre-astro 5.3 patch) running on my Mac is having two problems with
seeing_profile
The version running on our Jupyter3 server doesn't appear to have an issue. Emily and I were able to extract the stellarphot codebase used on Jupyter3, and comparing it to the current codebase there seemed to be NO relevant differences in
stellarphot.visualization.seeing_profile_functions.py
in the two versions (e.g. - only differences was in__all__
list and innp.int
being replaced withint
in the newer code).The text was updated successfully, but these errors were encountered: