Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change in non-public fitting API in astropy >=5.1 broke transit fitting #91

Closed
mwcraig opened this issue May 30, 2023 · 0 comments · Fixed by #92
Closed

Change in non-public fitting API in astropy >=5.1 broke transit fitting #91

mwcraig opened this issue May 30, 2023 · 0 comments · Fixed by #92
Assignees
@JuanCab

Comments

@mwcraig
Copy link
Contributor

mwcraig commented May 30, 2023

The __call__ method of VariableArgsFitter was a copy-paste from the astropy LevMarLSQFitter that allowed for an arbitrary number of arguments. I think that method changed in 5.1 and the transit fitting code in this repo has never been updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuanCab JuanCab

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mwcraig @JuanCab