Remove undisplay MUR disposition category #6047
Open
+112
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/public-20241112 #6047 +/- ##
===========================================================
- Coverage 86.59% 86.58% -0.02%
===========================================================
Files 82 82
Lines 9080 9088 +8
===========================================================
+ Hits 7863 7869 +6
- Misses 1217 1219 +2 ☔ View full report in Codecov by Sentry. |
pkfec
reviewed
Nov 7, 2024
|
|
||
| # Get the allowed displayed MUR disposition category list from table fecmur.ref_case_disposition_category | ||
| category_list = [dict(row) for row in conn.execute(CASE_DISPOSITION_CATEGORY, "MUR")] | ||
| # print(category_list): |
fec-jli
changed the title
fec-jli
force-pushed
the
feature/get_mur_adr_disposition_category_from_table
branch
from
916d7f1
to
aefd985
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary (required)
This PR add a new table (fecmur.ref_case_disposition_category) to store displayed final disposition categories for three cases (MUR, ADR and AF)
The new MUR disposition category list:
ref_case_disposition_category.csv
Required reviewers
1-2 developers
Impacted areas of the application
legal search endpoint
Completion criteria
Related PRs
#5988
#5991
How to test
1)Checkout branch
2)Setup local ES
3Upload legal doc on local ES.
These commands for reference:
python cli.py create_index case_indexpython cli.py delete_index case_indexpython cli.py load_adrspython cli.py load_admin_finespython cli.py load_current_murspython cli.py load_current_murs 81824)
pytestandflask run5)Test urls
http://127.0.0.1:5000/v1/legal/search/?type=murs&case_no=8182
there are 8 items under
dispositionssection that allmur_disposition_category_id": 6,compare with prod:
https://api.open.fec.gov/v1/legal/search?type=murs&case_no=8182
&api_key=DEMO_KEY
There are 9 items under
dispositionssection (mur_disposition_category_id": 12,)that include one unpublished dispositon
mur_disposition_category_id": "37",6)make sure filter by mur_disposition_category_id work correctly
http://127.0.0.1:5000/v1/legal/search/?type=murs&mur_disposition_category_id=6
7)test in dev (MUR documents already are upload to dev)
https://fec-dev-api.app.cloud.gov/v1/legal/search?type=murs&case_no=8182&api_key=DEMO_KEY