-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mur disposition category filter #5988
Conversation
33fce23
to
fee2946
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5988 +/- ##
===========================================
+ Coverage 86.70% 86.73% +0.02%
===========================================
Files 82 82
Lines 8975 8979 +4
===========================================
+ Hits 7782 7788 +6
+ Misses 1193 1191 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @fec-jli!
query to get MUR_ADR disposition category list: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing job @fec-jli
Summary
Add filter by mur_disposition_category_id in the /legal/search/ endpoint.
Here is the list of Mur dispostion category list
Required reviewers
2 devs
Impacted areas of the application
/legal/search/
Completion criteria
How to test
1)Checkout branch
2)Setup local ES
3Upload legal doc on local ES.
These commands for reference:
python cli.py create_index case_index
python cli.py delete_index case_index
python cli.py load_adrs
python cli.py load_admin_fines
python cli.py load_current_murs
you can terminate(Ctr+C) in the middle of loading.
4)
pytest
andflask run
5)Test urls
http://127.0.0.1:5000/v1/legal/search/?type=murs&mur_disposition_category_id=12
http://127.0.0.1:5000/v1/legal/search/?type=murs&mur_disposition_category_id=7
http://127.0.0.1:5000/v1/legal/search/?type=murs&mur_disposition_category_id=12&mur_disposition_category_id=7
on dev:
https://fec-dev-api.app.cloud.gov/v1/legal/search?api_key=DEMO_KEY&type=murs&mur_disposition_category_id=1
multi-filter:
https://fec-dev-api.app.cloud.gov/v1/legal/search?api_key=DEMO_KEY&type=murs&mur_disposition_category_id=1&mur_disposition_category_id=12