Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mur disposition ids #6550

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

johnnyporkchops
Copy link
Contributor

@johnnyporkchops johnnyporkchops commented Nov 12, 2024

Summary (required)

Update mur disposition ids

Required reviewers

one developer

Impacted areas of the application

mur search disposition filter

How to test

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.91%. Comparing base (e73dd1b) to head (05e3378).

Additional details and impacted files
@@                   Coverage Diff                    @@
##           release/public-20241112    #6550   +/-   ##
========================================================
  Coverage                    79.91%   79.91%           
========================================================
  Files                          235      235           
  Lines                         5147     5147           
========================================================
  Hits                          4113     4113           
  Misses                        1034     1034           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cnlucas cnlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked numbers with Jun's list. Looks good to me thank you @johnnyporkchops

Copy link
Member

@patphongs patphongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cnlucas cnlucas merged commit ac4f82d into release/public-20241112 Nov 12, 2024
3 checks passed
@cnlucas cnlucas deleted the feature/update-mur-disposition-ids branch November 12, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants